doc, http: add rejectNonStandardBodyWrites option, clear its behaviour#53396
doc, http: add rejectNonStandardBodyWrites option, clear its behaviour#53396nodejs-github-bot merged 2 commits intonodejs:mainfrom
rejectNonStandardBodyWrites option, clear its behaviour#53396Conversation
|
Review requested:
|
Commit Queue failed- Loading data for nodejs/node/pull/53396 ✔ Done loading data for nodejs/node/pull/53396 ----------------------------------- PR info ------------------------------------ Title doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour (#53396) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-53035 -> nodejs:main Labels http, doc, author ready Commits 2 - doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour - fixup! Committers 1 - jakecastelli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/53396 Fixes: https://github.com/nodejs/node/issues/53035 Reviewed-By: Luigi Pinca Reviewed-By: Paolo Insogna Reviewed-By: Ulises Gascón Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53396 Fixes: https://github.com/nodejs/node/issues/53035 Reviewed-By: Luigi Pinca Reviewed-By: Paolo Insogna Reviewed-By: Ulises Gascón Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Jun 2024 15:57:36 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53396#pullrequestreview-2106362720 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107371369 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107511309 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107859286 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2109979771 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53396 From https://github.com/nodejs/node * branch refs/pull/53396/merge -> FETCH_HEAD ✔ Fetched commits as 94c81784422e..1112d9752552 -------------------------------------------------------------------------------- [main 401a614dcc] doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour Author: jakecastelli <[email protected]> Date: Mon Jun 10 01:24:07 2024 +0930 1 file changed, 7 insertions(+), 2 deletions(-) [main b7db59c059] fixup! Author: jakecastelli <[email protected]> Date: Mon Jun 10 01:31:30 2024 +0930 1 file changed, 1 insertion(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9468967820 |
|
Landed in 521c9c6 |
PR-URL: #53396 Fixes: #53035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: nodejs#53396 Fixes: nodejs#53035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: nodejs#53396 Fixes: nodejs#53035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #53396 Fixes: #53035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #53396 Fixes: #53035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Document
rejectNonStandardBodyWritesoption and its behaviour. Make the documentation clear that rejection only happens whenrejectNonStandardBodyWritesis set to true.Fixes: #53035
Refs: #47732 (comment), #47480