test: update TLS tests for OpenSSL 3.2 by richardlau · Pull Request #53384 · nodejs/node

richardlau · 2024-06-07T16:43:23Z

Update the following TLS tests to account for error code changes in OpenSSL 3.2 and later.

parallel/test-tls-empty-sni-context
parallel/test-tls-psk-circuit

Refs: #53382
Refs: openssl/openssl#19950

cc @nodejs/crypto

Addresses these failures with OpenSSL 3.2:

not ok 3051 parallel/test-tls-empty-sni-context
  ---
  duration_ms: 107.38800
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:126
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected
    
    + 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE'
    - 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE'
        at TLSSocket.<anonymous> (/home/nodejs/node/test/parallel/test-tls-empty-sni-context.js:29:12)
        at TLSSocket.<anonymous> (/home/nodejs/node/test/common/index.js:466:15)
        at TLSSocket.emit (node:events:520:28)
        at emitErrorNT (node:internal/streams/destroy:170:8)
        at emitErrorCloseNT (node:internal/streams/destroy:129:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE',
      expected: 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE',
      operator: 'strictEqual'
    }
    
    Node.js v23.0.0-pre
  ...
not ok 3135 parallel/test-tls-psk-circuit
  ---
  duration_ms: 130.16900
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:126
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected
    
    + 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE'
    - 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE'
        at TLSSocket.<anonymous> (/home/nodejs/node/test/parallel/test-tls-psk-circuit.js:52:16)
        at TLSSocket.<anonymous> (/home/nodejs/node/test/common/index.js:466:15)
        at TLSSocket.emit (node:events:520:28)
        at emitErrorNT (node:internal/streams/destroy:170:8)
        at emitErrorCloseNT (node:internal/streams/destroy:129:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE',
      expected: 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE',
      operator: 'strictEqual'
    }
    
    Node.js v23.0.0-pre
  ...

Update the following TLS tests to account for error code changes in OpenSSL 3.2 and later. - `parallel/test-tls-empty-sni-context` - `parallel/test-tls-psk-circuit`

nodejs-github-bot · 2024-06-07T18:19:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59687/

nodejs-github-bot · 2024-06-09T16:50:10Z

Landed in ce531af

sebastianas · 2024-06-11T19:19:02Z

The failure in test/parallel/test-http2-https-fallback.js is due to openssl/openssl#24338
It looks like node was testing an error behavior with error code but now an error is returned.

sebastianas · 2024-06-11T19:25:06Z

One question: For the tests, OpenSSL 3.0,3.1,3.2,3.3 have the same ABI. Would it be possible to compare the version against the version as returned by OpenSSL_version_num() (current library version) instead the version of openssl it was compiled against (constants.OPENSSL_VERSION_NUMBER)?

richardlau · 2024-06-12T16:36:38Z

I think it should be possible, but we'll run into the same issue as #51007 (comment) where the values are being captured in the snapshot and somehow need to be reset (I'm not entirely sure how).

Update the following TLS tests to account for error code changes in OpenSSL 3.2 and later. - `parallel/test-tls-empty-sni-context` - `parallel/test-tls-psk-circuit` PR-URL: #53384 Refs: #53382 Refs: openssl/openssl#19950 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

Update the following TLS tests to account for error code changes in OpenSSL 3.2 and later. - `parallel/test-tls-empty-sni-context` - `parallel/test-tls-psk-circuit` PR-URL: nodejs#53384 Refs: nodejs#53382 Refs: openssl/openssl#19950 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

Update the following TLS tests to account for error code changes in OpenSSL 3.2 and later. - `parallel/test-tls-empty-sni-context` - `parallel/test-tls-psk-circuit` PR-URL: #53384 Refs: #53382 Refs: openssl/openssl#19950 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

Refs: nodejs#53382 Refs: nodejs#53384 Same change as in 53384 where OpenSSL32 returns a slightly different error but for a different test. Signed-off-by: Michael Dawson <[email protected]>