Skip to content

test: move cluster tests to parallel #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

test: move cluster tests to parallel #4774

Trott wants to merge 1 commit into from
+0 −0

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jan 20, 2016

Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: #4736
Ref: #4739

@Trott Trott added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Jan 20, 2016
@Trott
test: move cluster tests to parallel
097ea9f 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: nodejs#4736
Ref: nodejs#4739
@jbergstroem
Copy link
Member

jbergstroem commented Jan 20, 2016

LGTM pre CI.

Edit: we already tested this in -J no?

@Trott
Copy link
Member Author

Trott commented Jan 20, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1311/

I don't think we've tested this with -J. Could cherry-pick it over to your branch and do that if you'd like.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 20, 2016

Changes LGTM

@jbergstroem
Copy link
Member

jbergstroem commented Jan 20, 2016

@Trott reckon we're fine. LGTM; fails seem unrelated.

Trott added a commit to Trott/io.js that referenced this pull request Jan 21, 2016
@Trott
test: move cluster tests to parallel
0634311 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: nodejs#4736
Ref: nodejs#4739
PR-URL: nodejs#4774
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 21, 2016

Landed in 0634311

@Trott Trott closed this Jan 21, 2016
@jasnell
Copy link
Member

jasnell commented Jan 23, 2016

@Trott ... should this be done in LTS also?

@Trott
Copy link
Member Author

Trott commented Jan 23, 2016

@jasnell I vote yes.

rvagg pushed a commit that referenced this pull request Jan 25, 2016
@Trott @rvagg
test: move cluster tests to parallel
e487b72 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: #4736
Ref: #4739
PR-URL: #4774
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@Trott
test: move cluster tests to parallel
7337e35 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: #4736
Ref: #4739
PR-URL: #4774
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@Trott
test: move cluster tests to parallel
068b0cb 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: #4736
Ref: #4739
PR-URL: #4774
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: move cluster tests to parallel
1c2955c 
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.

Ref: nodejs#4736
Ref: nodejs#4739
PR-URL: nodejs#4774
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>