[v16.x backport] WPT runner update and crypto followups by panva · Pull Request #44872 · nodejs/node

panva · 2022-10-03T09:12:44Z

Backports (in order):

PR-URL: nodejs#44196 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#44166 Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>

PR-URL: nodejs#43200 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

PR-URL: nodejs#44184 Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>

PR-URL: nodejs#44216 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

PR-URL: nodejs#44231 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Mark `test-http-pipeline-requests-connection-leak` flaky on IBM i. PR-URL: nodejs#44215 Refs: nodejs#43509 Refs: nodejs#39683 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

PR-URL: nodejs#44230 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: nodejs#44229 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Fixes: nodejs#44123 PR-URL: nodejs#44248 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: nodejs#44233 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Feng Yu <[email protected]>

If the exception is handled by the userland process#uncaughtException handler, reports should not be generated repetitively as the process may continue to run. PR-URL: nodejs#44208 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>

PR-URL: nodejs#44217 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: nodejs#44244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#43253 Reviewed-By: Erick Wendel <[email protected]>

Use the logical OR operator instead of the ternary operator where applicable. PR-URL: nodejs#44236 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

PR-URL: nodejs#44243 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#44235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: nodejs#43474 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: nodejs#44263 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

While copying BaseObjectPtrs is cheap, it is not a no-op, so it is best to iterate over references to BaseObjectPtrs only. PR-URL: nodejs#44270 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Filenames `stdout` and `stderr` have special meanings when writing the report. PR-URL: nodejs#44257 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Extract common context embedder tag checks to ContextEmbedderTag so that verifying if a context is a node context doesn't need to access private members of node::Environment. PR-URL: nodejs#44258 Refs: nodejs#44179 Refs: nodejs#44252 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Add section with high level approach/requirements for enabling TypeScript execution as discussed in the Next-10 [TypeScript mini-summit](nodejs/next-10#150) Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#44030 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: nodejs#44271 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

KeyPairGenTraits::EncodeKey should not use an object that it previously moved. Make ManagedEVPPKey::ToEncoded(Public|Private)Key non-static members of ManagedEVPPKey and call them on the key object instead. PR-URL: nodejs#44269 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Feng Yu <[email protected]>

PR-URL: nodejs#44262 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The callback argument is required. PR-URL: nodejs#44311 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: nodejs#44284 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs#44321 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#43455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44172 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44173 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44223 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Backport-PR-URL: nodejs#44872

Some tests expect it to be empty so clear it again after running a regular expression against /proc/cpuinfo. It didn't cause test failures on any of the CI machines, to the best of my knowledge, because most of the time /proc/cpuinfo doesn't contain the string it was looking for. Fixes: nodejs#44840 PR-URL: nodejs#44864 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: nodejs#44707 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: nodejs#43455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44172 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44173 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

PR-URL: nodejs#44223 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Backport-PR-URL: nodejs#44872

nodejs-github-bot · 2022-10-08T21:04:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47129/

We run all WPT from one subset in the same process using workers. As the number of the tests grow, it can take longer to run some of the subsets, but it's still overall faster than running them in different processes. This patch increases the timeout for WPT to prevent the test from failing because it takes longer to run (even though it would still complete at some point). PR-URL: nodejs#44574 Refs: nodejs/reliability#371 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

nodejs-github-bot · 2022-10-09T06:02:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47134/

juanarbol · 2022-10-11T04:51:19Z

Landed in bc20e47...54b9635 🎉 💚

Muchas gracias!

fossamagna and others added 30 commits September 23, 2022 11:49

test: use mustSucceed instead of mustCall with assert.ifError

38d92ab

PR-URL: nodejs#44196 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

doc: improved building doc for Android

ccfdb47

PR-URL: nodejs#44166 Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>

build: enable pointer authentication for branch protection on arm64

68aaec5

PR-URL: nodejs#43200 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

src: fix --heapsnapshot-near-heap-limit error hint

1e3ea5f

PR-URL: nodejs#44216 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

meta: update AUTHORS

f2dc7c2

PR-URL: nodejs#44231 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]>

test: mark connection leak test flaky on IBM i

1338afb

Mark `test-http-pipeline-requests-connection-leak` flaky on IBM i. PR-URL: nodejs#44215 Refs: nodejs#43509 Refs: nodejs#39683 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

tools: update lint-md-dependencies to [email protected]

89a3ed6

PR-URL: nodejs#44230 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

deps: update corepack to 0.12.3

ab60ceb

PR-URL: nodejs#44229 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Rich Trott <[email protected]>

doc: add cola119 to collaborators

1bc2090

Fixes: nodejs#44123 PR-URL: nodejs#44248 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

http: add max for http keepalive

c6c77d0

PR-URL: nodejs#44217 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

tools: update lint-md-dependencies to [email protected]

57eb268

PR-URL: nodejs#44244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

trace_events: add example

993cf51

PR-URL: nodejs#43253 Reviewed-By: Erick Wendel <[email protected]>

tools: update ESLint to 8.22.0

0759337

PR-URL: nodejs#44243 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

meta: update web streams in label-pr-config

00bc140

Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#44235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

lib: refactor to avoid prototype pollution

807a659

PR-URL: nodejs#43474 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>

deps: upgrade npm to 8.18.0

bb91f62

PR-URL: nodejs#44263 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

doc: fix optionality of callback arg of checkPrime

ce1a3e2

The callback argument is required. PR-URL: nodejs#44311 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

test_runner: fix test runner hooks failure stack

2b9e88d

PR-URL: nodejs#44284 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

meta: update AUTHORS

34d4fb2

PR-URL: nodejs#44321 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

juanarbol force-pushed the v16.x-staging branch from 95e26ff to 71615ce Compare October 7, 2022 13:29

panva force-pushed the backport-lots-to-v16.x branch from b758f43 to 1805fe0 Compare October 7, 2022 17:56

panva added a commit to panva/node that referenced this pull request Oct 7, 2022

test: update WPT runner

b301c7c

PR-URL: nodejs#43455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Backport-PR-URL: nodejs#44872

panva added a commit to panva/node that referenced this pull request Oct 7, 2022

crypto: fix webcrypto EC key namedCurve validation errors

14aca3d

PR-URL: nodejs#44172 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

panva added a commit to panva/node that referenced this pull request Oct 7, 2022

crypto: fix webcrypto deriveBits validations

2f9c180

PR-URL: nodejs#44173 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

panva added a commit to panva/node that referenced this pull request Oct 7, 2022

crypto: allow zero-length secret KeyObject

46b9ff3

PR-URL: nodejs#44201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

github-actions bot mentioned this pull request Oct 8, 2022

CI Reliability 2022-10-08 nodejs/reliability#398

Open

20 tasks

bnoordhuis and others added 10 commits October 8, 2022 15:23

test: loosen test for negative timestamps in test-fs-stat-date

02cd9a9

PR-URL: nodejs#44707 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

test: update WPT runner

6648459

PR-URL: nodejs#43455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Backport-PR-URL: nodejs#44872

crypto: fix webcrypto generateKey() AES key length validation error

272503f

PR-URL: nodejs#44170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

crypto: fix webcrypto operation errors to be OperationError

af8eb95

PR-URL: nodejs#44171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

crypto: fix webcrypto EC key namedCurve validation errors

3003a81

PR-URL: nodejs#44172 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

crypto: fix webcrypto deriveBits validations

e8695cd

PR-URL: nodejs#44173 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

crypto: allow zero-length secret KeyObject

8492b7c

PR-URL: nodejs#44201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2

a9db719

PR-URL: nodejs#44201 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#44872

panva force-pushed the backport-lots-to-v16.x branch from 1805fe0 to 1d9738a Compare October 8, 2022 21:03

github-actions bot mentioned this pull request Oct 9, 2022

CI Reliability 2022-10-09 nodejs/reliability#399

Open

18 tasks

This was referenced Oct 10, 2022

CI Reliability 2022-10-10 nodejs/reliability#400

Open

CI Reliability 2022-10-11 nodejs/reliability#401

Open

github-actions bot mentioned this pull request Oct 12, 2022

CI Reliability 2022-10-12 nodejs/reliability#402

Open

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[v16.x backport] WPT runner update and crypto followups#44872

[v16.x backport] WPT runner update and crypto followups#44872
panva wants to merge 336 commits intonodejs:v16.x-stagingfrom
panva:backport-lots-to-v16.x

panva commented Oct 3, 2022 •

edited

Loading

Uh oh!

nodejs-github-bot commented Oct 8, 2022

Uh oh!

nodejs-github-bot commented Oct 9, 2022

Uh oh!

juanarbol commented Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

panva commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 8, 2022

Uh oh!

nodejs-github-bot commented Oct 9, 2022

Uh oh!

juanarbol commented Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

panva commented Oct 3, 2022 •

edited

Loading