crypto: remove Node.js-specific Web Crypto API extensions #43310

panva · 2022-06-04T06:38:50Z

This PR removes Node.js specific extensions from Web Crypto API.

Removes 'NODE-DSA', 'NODE-DH', and 'NODE-SCRYPT' algorithms.
Removes 'node.keyObject' import/export format.

These extensions are not portable and the crypto Issues and PRs related to the crypto subsystem. module accomodates their functionality.

After this cleanup the webcrypto module has a clearer path to stable stability status.

NB: src code cleanup will follow in a separate PR.

nodejs-github-bot · 2022-06-04T06:38:54Z

Review requested:

@nodejs/crypto

devsnek · 2022-06-04T06:45:45Z

could NODE-ED25519 theoretically be an alias of Ed25519? i'm not very familiar with the differences

panva · 2022-06-04T06:51:02Z

could NODE-ED25519 theoretically be an alias of Ed25519? i'm not very familiar with the differences

NODE-ED25519 was removed from webcrypto in #42507. The difference was not only in the name of the algorithm.

doc/api/webcrypto.md

nodejs-github-bot · 2022-06-04T12:49:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44355/

panva · 2022-06-04T16:46:29Z

Only three resumes 🚀

nodejs-github-bot · 2022-06-11T06:49:20Z

Commit Queue failed

- Loading data for nodejs/node/pull/43310 ✔ Done loading data for nodejs/node/pull/43310 ----------------------------------- PR info ------------------------------------ Title crypto: remove Node.js-specific Web Crypto API extensions (#43310) Author Filip Skokan (@panva) Branch panva:webcrypto-remove-extensions -> nodejs:master Labels crypto, semver-minor, lib / src, notable-change, experimental, author ready, needs-ci, webcrypto Commits 2 - crypto: remove Node.js-specific webcrypto extensions - fixup! crypto: remove Node.js-specific Web Crypto API extensions Committers 2 - Filip Skokan - GitHub PR-URL: https://github.com/nodejs/node/pull/43310 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43310 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 04 Jun 2022 06:38:50 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43310#pullrequestreview-995799532 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-06-04T12:49:53Z: https://ci.nodejs.org/job/node-test-pull-request/44355/ - Querying data for job/node-test-pull-request/44355/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 43310 From https://github.com/nodejs/node * branch refs/pull/43310/merge -> FETCH_HEAD ✔ Fetched commits as cb7e854c776d..2367fa298973 -------------------------------------------------------------------------------- [master 31dcf796f2] crypto: remove Node.js-specific webcrypto extensions Author: Filip Skokan Date: Thu Jun 2 10:41:00 2022 +0200 25 files changed, 40 insertions(+), 1901 deletions(-) delete mode 100644 lib/internal/crypto/dsa.js delete mode 100644 test/fixtures/crypto/dsa.js delete mode 100644 test/parallel/test-webcrypto-derivebits-node-dh.js delete mode 100644 test/parallel/test-webcrypto-export-import-dsa.js delete mode 100644 test/parallel/test-webcrypto-sign-verify-node-dsa.js [master 7e3574df4c] fixup! crypto: remove Node.js-specific Web Crypto API extensions Author: Filip Skokan Date: Sat Jun 4 08:52:21 2022 +0200 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
crypto: remove Node.js-specific webcrypto extensions

PR-URL: #43310
Reviewed-By: James M Snell [email protected]

[detached HEAD 8ff08e780e] crypto: remove Node.js-specific webcrypto extensions
Author: Filip Skokan [email protected]
Date: Thu Jun 2 10:41:00 2022 +0200
25 files changed, 40 insertions(+), 1901 deletions(-)
delete mode 100644 lib/internal/crypto/dsa.js
delete mode 100644 test/fixtures/crypto/dsa.js
delete mode 100644 test/parallel/test-webcrypto-derivebits-node-dh.js
delete mode 100644 test/parallel/test-webcrypto-export-import-dsa.js
delete mode 100644 test/parallel/test-webcrypto-sign-verify-node-dsa.js
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! crypto: remove Node.js-specific Web Crypto API extensions

PR-URL: #43310
Reviewed-By: James M Snell [email protected]

[detached HEAD 5dae70fa18] fixup! crypto: remove Node.js-specific Web Crypto API extensions
Author: Filip Skokan [email protected]
Date: Sat Jun 4 08:52:21 2022 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/2479089075

Notable changes: * crypto: * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * add CFRG curves to Web Crypto API (Filip Skokan) #42507 * report: * add more heap infos in process report (theanarkh) #43116 PR-URL: #43385

ljharb · 2022-06-16T15:05:58Z

How is this PR not semver-major? It removes things.

panva · 2022-06-16T15:08:54Z

How is this PR not semver-major? It removes things.

The webcrypto module is experimental Issues and PRs related to experimental features. .

ljharb · 2022-06-16T17:18:06Z

Ah, thanks for clarifying.

yoursunny · 2022-06-24T01:31:52Z

How is this PR not semver-major? It removes things.

If you need to write code that supports both Node 18.4.0 and earlier version, you can try my library:
@yoursunny/webcrypto-ed25519.

It exports an Ed25519Algorithm variable that is { name: "Ed25519" } for Node 18.4.0 or { name: "NODE-ED25519", namedCurve: "NODE-ED25519" } for Node 18.3.0 and earlier.
Pass this variable to Web Crypto API instead of the algorithm object, and you can support both versions.

crypto: remove Node.js-specific webcrypto extensions

2879518

panva requested review from jasnell and tniessen June 4, 2022 06:38

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 4, 2022

panva commented Jun 4, 2022

View reviewed changes

doc/api/webcrypto.md Outdated Show resolved Hide resolved

panva commented Jun 4, 2022

View reviewed changes

doc/api/webcrypto.md Outdated Show resolved Hide resolved

fixup! crypto: remove Node.js-specific Web Crypto API extensions

2367fa2

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 4, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 4, 2022

This comment was marked as outdated.

Sign in to view

jasnell approved these changes Jun 4, 2022

View reviewed changes

panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2022

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 11, 2022

panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 11, 2022

styfle mentioned this pull request Jun 17, 2022

Document how to reference a label in GitHub-flavored Markdown github/docs#18537

Closed

1 task

targos mentioned this pull request Aug 2, 2022

v16.17.0 release proposal #44098

Merged

ItalyPaleAle mentioned this pull request Sep 3, 2022

Methods fail with Miniflare and Node.js 18.4+ panva/jose#446

Closed

2 tasks

panva mentioned this pull request Jan 3, 2023

doc,crypto: fix WebCryptoAPI import keyData and export return #46076

Merged

GeoffreyParrier mentioned this pull request Nov 6, 2025

Ability to mention labels refined-github/refined-github#8736

Closed

Uh oh!

crypto: remove Node.js-specific Web Crypto API extensions #43310

crypto: remove Node.js-specific Web Crypto API extensions #43310

Uh oh!

Conversation

panva commented Jun 4, 2022

Uh oh!

nodejs-github-bot commented Jun 4, 2022

Uh oh!

devsnek commented Jun 4, 2022

Uh oh!

panva commented Jun 4, 2022

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jun 4, 2022

Uh oh!

panva commented Jun 4, 2022

Uh oh!

nodejs-github-bot commented Jun 11, 2022

PR-URL: #43310 Reviewed-By: James M Snell [email protected]

PR-URL: #43310 Reviewed-By: James M Snell [email protected]

Successfully rebased and updated refs/heads/master.

Uh oh!

ljharb commented Jun 16, 2022

Uh oh!

panva commented Jun 16, 2022

Uh oh!

ljharb commented Jun 16, 2022

Uh oh!

yoursunny commented Jun 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PR-URL: #43310
Reviewed-By: James M Snell [email protected]

PR-URL: #43310
Reviewed-By: James M Snell [email protected]