Skip to content

deps: update V8 to 10.1 #42657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 21 commits into from
Closed

deps: update V8 to 10.1 #42657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a5cecb3
deps: update V8 to 10.1.124.6
targos Apr 12, 2022
f4df3c5
build: reset embedder string to "-node.0"
targos Apr 12, 2022
9be688c
src: update NODE_MODULE_VERSION to 108
targos Apr 8, 2022
4f4d0a5
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
1db7e5b
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
4451f9e
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
f5e32e9
deps: disable trap handler for Windows cross-compiler
targos Oct 20, 2021
b253a3a
deps: silence V8's warning on CompileFunction
targos Nov 22, 2021
3d77c09
deps: V8: fix v8-cppgc.h for MSVC
gengjiawen Mar 17, 2022
1a07ddf
deps: make V8 compilable with older glibc
targos Mar 18, 2022
3d27658
deps: V8: cherry-pick 87ce4f5d98a5
targos Apr 5, 2022
f97c5c9
deps: V8: cherry-pick a2cae2180a7a
targos Apr 9, 2022
15e00ca
deps: V8: cherry-pick ca2a787a0b49
targos Apr 12, 2022
32d70cd
deps: V8: cherry-pick 4c29cf1b7885
targos Apr 12, 2022
5a7a632
deps: V8: cherry-pick ad21d212fc14
targos Apr 12, 2022
9aabac8
deps: V8: cherry-pick semver-major commits from 10.2
targos Apr 12, 2022
a398c24
tools,test: fix V8 initialization order
camillobruni Dec 9, 2021
bdefa66
tools: update V8 gypfiles for 10.1
targos Dec 15, 2021
827bdb7
test: adapt test-v8-serdes for V8 9.9
targos Feb 24, 2022
da62d9e
test: adapt test-worker-debug for V8 10.0
targos Feb 25, 2022
6c5b764
test: adapt message tests for V8 10.2
targos Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 87ce4f5d98a5 
Original commit message:

    [ic] use CSA_DCHECK in CodeStubAssembler::SharedValueBarrier

    Since the code is generated unconditionally, using a DCHECK to check
    that shared RO heap is enabled breaks builds with
    v8_enable_shared_ro_heap set to false, this patch turns that into a
    CSA_DCHECK so it only crashes when V8 actually attempts to store into
    a shared struct while the RO heap isn't shared at run time.

    Refs: #42115
    Bug: v8:12547
    Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598
    Reviewed-by: Shu-yu Guo <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#79756}

Refs: v8/v8@87ce4f5
  • Loading branch information
@targos
targos committed Apr 12, 2022
commit 3d276586ce6eae0b021983ad94465a835a13fc06
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/codegen/code-stub-assembler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15953,7 +15953,7 @@ void CodeStubAssembler::SharedValueBarrier(
GotoIf(TaggedIsSmi(value), &done);
// Fast path: Shared memory features imply shared RO space, so RO objects are
// trivially shared.
DCHECK(ReadOnlyHeap::IsReadOnlySpaceShared());
CSA_DCHECK(this, BoolConstant(ReadOnlyHeap::IsReadOnlySpaceShared()));
TNode<IntPtrT> page_flags = LoadBasicMemoryChunkFlags(CAST(value));
GotoIf(WordNotEqual(WordAnd(page_flags,
IntPtrConstant(BasicMemoryChunk::READ_ONLY_HEAP)),
Expand Down