Skip to content

Add direct access to rss without iterating pages#34291

Closed
Aschen wants to merge 1 commit intonodejs:masterfrom
kuzzleio:add-direct-access-to-rss
Closed

Add direct access to rss without iterating pages#34291
Aschen wants to merge 1 commit intonodejs:masterfrom
kuzzleio:add-direct-access-to-rss

Conversation

@Aschen
Copy link

@Aschen Aschen commented Jul 10, 2020 •
edited
Loading

Accessing the rss value through process.memoryUsage().rss can be expensive because this method will also generate memory usage statistics by iterating on each page.

The overhead can be quite huge when a lot of memory has been allocated, consider this snippet:

rss-access.js 
const ar = []

for (let i = parseInt(process.argv[2], 10); i--; ) {
  ar.push({
    very: 'This is a lot of datazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz',
    big: {
      object: 'I m blue tadoudidadouda I m blue tadoudidadouda I m blue tadoudidadouda'
    }
  })
}

let start = process.hrtime();

process.memoryUsage().rss

let hrend = process.hrtime(start);

console.log(hrend[1] / 1000000, 'memoryUsage()');

start = process.hrtime();

process.rss()

hrend = process.hrtime(start);

console.log(hrend[1] / 1000000, 'rss()')

$ ./out/Release/node test.js 1000
0.361226 memoryUsage()
0.05305 rss()

$ ./out/Release/node test.js 10000000
1.208851 memoryUsage()
0.075418 rss()

This PR aim to offer an API to access directly the rss value in a (almost) constant time.

// Don't
process.memoryUsage().rss;

// Do
process.memoryUsage.rss();
EDIT: 2020-07-13

Following @bnoordhuis proposal I added a rssOnly option to process.memoryUsage instead of adding the new process.rss method:

process.memoryUsage({ rssOnly: true });
{
  rss: 36270080,
  heapTotal: 0,
  heapUsed: 0,
  external: 0,
  arrayBuffers: 0
}
EDIT: 2020-08-11

Following @jasnell and @bnoordhuis advices the rss value is now accessible through process.memoryUsage.rss

See #33384

Checklist
  • [/] make -j4 test (UNIX), or vcbuild test (Windows) passes (Unix is ok but unfortunately I don't have a windows computer)
  • tests and/or benchmarks are included
  • documentation is changed or added (I will add the documentation once we agree on the API)
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Jul 10, 2020
bnoordhuis
bnoordhuis reviewed Jul 10, 2020
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your (and everyone else's) consideration, perhaps:

  • the os module is a more appropriate place for a new method?

  • instead of a new method, make process.memoryUsage() take an optional { rssOnly: true } options object?

test/parallel/test-memory-usage.js Outdated
Copy link
Member

@bnoordhuis bnoordhuis Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not reliable because the RSS can change between the two calls.

src/node_process_methods.cc Outdated
Comment on lines 168 to 175
Copy link
Member

@bnoordhuis bnoordhuis Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Get the double array pointer from the Float64Array argument.
CHECK(args[0]->IsFloat64Array());
Local<Float64Array> array = args[0].As<Float64Array>();
CHECK_EQ(array->Length(), 1);
Local<ArrayBuffer> ab = array->Buffer();
double* fields = static_cast<double*>(ab->GetBackingStore()->Data());
fields[0] = rss;
args.GetReturnValue().Set(static_cast<double>(rss));

Float64Array is overkill if you're returning a single floating-point value. You can expose the method directly, without going through a JS method first.

@Aschen
Copy link
Author

Aschen commented Jul 10, 2020

@bnoordhuis

IMHO the os module is not the right place for that because as far as I understand it's information about the whole OS and not the currently running process.

But I like your idea of a { rssOnly: true } option object 👍

@BridgeAR
Copy link
Member

BridgeAR commented Jul 10, 2020

Note: I'm not happy with the process.rss API, if someone have a better suggestion I'm in 👍

It would be possible to use process.memoryUsage.rss();. I am not certain if this might be confusing for some people though.

@Aschen
Copy link
Author

Aschen commented Jul 10, 2020

It would be possible to use process.memoryUsage.rss();. I am not certain if this might be confusing for some people though.

I thought about this one but I couldn't figure an easy way to document it since it will involve a property on a function which is a function

@Aschen
Copy link
Author

Aschen commented Jul 13, 2020

@bnoordhuis I updated the PR with the rssOnly option so you may want to review the code again

bnoordhuis
bnoordhuis reviewed Jul 13, 2020
View reviewed changes
test/parallel/test-memory-usage.js Outdated
Copy link
Member

@bnoordhuis bnoordhuis Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const result = process.memoryUsage({ rssOnly: true });
process.memoryUsage();
const result = process.memoryUsage({ rssOnly: true });

Then re-run the test. :-)

(You need to clear the other fields when rssOnly=true or they'll contain stale values.)

test/parallel/test-worker-memory.js Outdated
Copy link
Member

@bnoordhuis bnoordhuis Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from the previous iteration of the PR? There's no process.rss() anymore.

@jasnell
Copy link
Member

jasnell commented Jul 14, 2020

@Aschen :

It would be possible to use process.memoryUsage.rss();. I am not certain if this might be confusing for some people though.

I thought about this one but I couldn't figure an easy way to document it since it will involve a property on a function which is a function

Take a look at the documentation for process.hrtime.bigint() for an example of this pattern. I think I'd prefer the process.memoryUsage.rss() approach also.

@Aschen
Copy link
Author

Aschen commented Jul 21, 2020

@bnoordhuis Are you also ok with the process.memoryUsage.rss() approach?

@bnoordhuis
Copy link
Member

bnoordhuis commented Jul 21, 2020

@Aschen Sure, there's precedent, e.g., fs.realpath.native().

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. review wanted PRs that need reviews. labels Nov 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Flarna
Flarna reviewed Nov 8, 2020
View reviewed changes
@Aschen
Copy link
Author

Aschen commented Nov 9, 2020

I got a strange error on the file node_snapshop.cc in the compilation even if I didn't modify this file 🤔

https://github.com/nodejs/node/pull/34291/checks?check_run_id=1371318709 
LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj/gen; "/home/runner/work/node/node/out/Release/node_mksnapshot" "/home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc"
Unknown external reference 0x55a462331140.
<unresolved>
Illegal instruction (core dumped)
node.target.mk:26: recipe for target '/home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc' failed
rm 2ad06b2c9baade6b27c5c82cdcc7af11c369378d.intermediate 9ac559b3661ef3e3ae7143f36ccc6691e578b31c.intermediate 02a486ff0aa87df511c38b125409357fdc559df2.intermediate 5e4cf980d3dc346b9b9ba01305d21285c5aecbf4.intermediate
make[2]: *** [/home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc] Error 132
Makefile:104: recipe for target 'node' failed
make[1]: *** [node] Error 2
Makefile:530: recipe for target 'build-ci' failed
make: *** [build-ci] Error 2
Error: Process completed with exit code 2.

Flarna
Flarna reviewed Nov 9, 2020
View reviewed changes
Flarna
Flarna reviewed Nov 9, 2020
View reviewed changes
Flarna
Flarna reviewed Nov 9, 2020
View reviewed changes
doc/api/process.md Outdated
Copy link
Member

@Flarna Flarna Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find can be slow quite vague - in special as a caller can't do anything to avoid this to test if it will be slow.
Are we talking about µs, ms, or seconds here?

Copy link
Author

@Aschen Aschen Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the program size in memory. Access the RSS take a fixed time but compute heap statistics is quite costly since you have to iterate over every memory page.
The difference can be in seconds. (see the benchmark in the PR description)

Copy link
Member

@Flarna Flarna Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample in PR description prints milli seconds not seconds so not that bad.
I tried it local on my machine and even for 4GB heaps it was below 0.2ms. But for sure the rss only API is much faster.

Copy link
Author

@Aschen Aschen Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the beginning I have done this PR because I found very strange results while benchmarking promises (#33384).
So even if the difference is not that huge it can be misleading in some cases

Flarna
Flarna reviewed Nov 10, 2020
View reviewed changes
@Flarna
Copy link
Member

Flarna commented Nov 10, 2020

I got a strange error on the file node_snapshop.cc in the compilation even if I didn't modify this file

I think you have to add registry->Register(Rss) in RegisterProcessMethodsExternalReferences (node_process_methods.cc).

@Flarna Flarna added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Flarna
Copy link
Member

Flarna commented Nov 17, 2020

@nodejs/process

jasnell
jasnell reviewed Nov 19, 2020
View reviewed changes
mhdawson pushed a commit that referenced this pull request Jan 8, 2021
@PoojaDurgad @mhdawson
test: use faster variant for rss test-memoryusage-emfile
db12ece 
PR-URL: #36768
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell pushed a commit that referenced this pull request Jan 11, 2021
@PoojaDurgad @jasnell
test: use faster variant for rss in test-vm-memleak.js
2ceb441 
PR-URL: #36769
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Jan 11, 2021
@PoojaDurgad @jasnell
test: use faster variant for rss in test-crypto-dh-leak
f4ef517 
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@danielleadams
process: add direct access to rss without iterating pages
92af503 
Accessing the rss value through memoryUsage() can be expensive
because this method will also generate  memory usage statistics
by iterating on each page.
This commit intend to offer a more direct access to rss value.

Refs: #33384

PR-URL: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Flarna @danielleadams
doc: add YAML metadata for process.memoryUsage.rss
8f672eb 
Refs: #34291

PR-URL: #36781
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@PoojaDurgad @danielleadams
test: use faster variant for rss test-memoryusage-emfile
c64db20 
PR-URL: #36768
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@PoojaDurgad @danielleadams
test: use faster variant for rss in test-vm-memleak.js
daad0ab 
PR-URL: #36769
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@PoojaDurgad @danielleadams
test: use faster variant for rss in test-crypto-dh-leak
cc37ff2 
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
danielleadams added a commit that referenced this pull request Jan 12, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
7994977 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 12, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
ce42dea 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2020-01-12, Version 15.6.0 (Current)
3d4c36b 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2020-01-13, Version 15.6.0 (Current)
cf44a24 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 13, 2021
@danielleadams
2021-01-13, Version 15.6.0 (Current)
1a5dbf3 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 14, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
4c6744c 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
danielleadams added a commit that referenced this pull request Jan 14, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
1700bbd 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) (#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
  * implement basic secure heap support (James M Snell) (#36779)
  * fixup bug in keygen error handling (James M Snell) (#36779)
  * introduce X509Certificate API (James M Snell) (#36804)
  * implement randomuuid (James M Snell) (#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) (#36793)
  * add dnlup to collaborators (Daniele Belardi) (#36849)
  * add panva to collaborators (Filip Skokan) (#36802)
  * add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
  * fix native  constructors (ExE Boss) (#36549)
danielleadams added a commit that referenced this pull request Jan 15, 2021
@danielleadams
2021-01-14, Version 15.6.0 (Current)
0f78948 
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) (#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
  * implement basic secure heap support (James M Snell) (#36779)
  * fixup bug in keygen error handling (James M Snell) (#36779)
  * introduce X509Certificate API (James M Snell) (#36804)
  * implement randomuuid (James M Snell) (#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) (#36793)
  * add dnlup to collaborators (Daniele Belardi) (#36849)
  * add panva to collaborators (Filip Skokan) (#36802)
  * add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
  * fix native  constructors (ExE Boss) (#36549)
aduh95 pushed a commit to PoojaDurgad/node that referenced this pull request Apr 3, 2021
@PoojaDurgad @aduh95
test: use faster variant for rss
4ad7338 
PR-URL: nodejs#36839
Refs: nodejs#34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@PoojaDurgad @MylesBorins
test: use faster variant for rss
6bf507f 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 5, 2021
@PoojaDurgad @MylesBorins
test: use faster variant for rss
0243376 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2021
@targos
process: add direct access to rss without iterating pages
e46b2e5 
Accessing the rss value through memoryUsage() can be expensive
because this method will also generate  memory usage statistics
by iterating on each page.
This commit intend to offer a more direct access to rss value.

Refs: #33384

PR-URL: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2021
@Flarna @targos
doc: add YAML metadata for process.memoryUsage.rss
bf061d6 
Refs: #34291

PR-URL: #36781
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2021
@PoojaDurgad @targos
test: use faster variant for rss test-memoryusage-emfile
67cc3cd 
PR-URL: #36768
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2021
@PoojaDurgad @targos
test: use faster variant for rss in test-vm-memleak.js
1661cf6 
PR-URL: #36769
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2021
@PoojaDurgad @targos
test: use faster variant for rss in test-crypto-dh-leak
dade545 
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2021
@PoojaDurgad @targos
test: use faster variant for rss
45bf825 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
@PoojaDurgad @BethGriggs
test: use faster variant for rss test-memoryusage-emfile
5b765e9 
PR-URL: #36768
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
@PoojaDurgad @BethGriggs
test: use faster variant for rss in test-vm-memleak.js
65195ab 
PR-URL: #36769
Refs: #34291
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments

@jasnell jasnell jasnell approved these changes

@Flarna Flarna Flarna approved these changes

+1 more reviewer

@devsnek devsnek devsnek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.