events:use property, primordials#33775
Closed
benjamingr wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
lundibundi
approved these changes
Jun 6, 2020
addaleax
approved these changes
Jun 6, 2020
himself65
approved these changes
Jun 7, 2020
benjamingr
added
the
author ready
jasnell
approved these changes
Jun 8, 2020
Collaborator
jasnell
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33775 Fixes: #33773 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in ea866dc |
codebytere
pushed a commit
that referenced
this pull request
Jun 22, 2020
PR-URL: #33775 Fixes: #33773 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33775 Fixes: #33773 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter.
This commit uses SymbolToStringTag from primordials and sets it as a property and not a getter.
Thank you Domenic for pointing this out!
Fixes: #33773
cc @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes