fs : update validateOffsetLengthRead in utils.js#32896
Closed
daemon1024 wants to merge 3 commits intonodejs:masterfrom
Closed
fs : update validateOffsetLengthRead in utils.js#32896daemon1024 wants to merge 3 commits intonodejs:masterfrom
daemon1024 wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
fs
Contributor
Author
|
node/test/parallel/test-fs-read-type.js Line 47 in 5a4f24e node/test/parallel/test-fs-read-type.js Line 76 in 5a4f24e node/test/parallel/test-fs-read-type.js Line 113 in 5a4f24e node/test/parallel/test-fs-read-type.js Line 139 in 5a4f24e Updating these in |
himself65
reviewed
Apr 17, 2020
Member
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
add a test case for <= ${bufferLength - offset}
addaleax
approved these changes
Apr 17, 2020
himself65
approved these changes
Apr 17, 2020
Collaborator
puzpuzpuz
approved these changes
Apr 23, 2020
Member
|
Landed in 1cc1ca4 Thanks for this improvement! |
puzpuzpuz
pushed a commit
that referenced
this pull request
Apr 23, 2020
PR-URL: #32896 Fixes: #32871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32896 Fixes: #32871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32896 Fixes: #32871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32896 Fixes: #32871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32896 Fixes: #32871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #32871
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes