Skip to content

deps: update V8 to 7.6#28016

Closed
ryzokuken wants to merge 20 commits intonodejs:masterfrom
ryzokuken:v8-7.6
Closed

deps: update V8 to 7.6#28016
ryzokuken wants to merge 20 commits intonodejs:masterfrom
ryzokuken:v8-7.6

Conversation

@ryzokuken
Copy link
Contributor

@ryzokuken ryzokuken commented Jun 2, 2019

🎉
Thanks @targos @refack

@cjihrig could you PTAL at 9106789138?

@ryzokuken ryzokuken requested review from refack and targos June 2, 2019 10:24
@ryzokuken
Copy link
Contributor Author

ryzokuken commented Jun 2, 2019

/cc @nodejs/v8-update

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos targos force-pushed the v8-7.6 branch 2 times, most recently from 28704ed to fe8bf54 Compare June 2, 2019 11:28
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 2, 2019 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/23554/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/

@targos

This comment has been minimized.

Sign in to view
@targos
Copy link
Member

targos commented Jun 2, 2019

@cjihrig Along with 9106789 (which I had to do to make it compile), we have some missing constants: v8dbg_class_FixedTypedArrayBase__base_pointer__Object,v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t,v8dbg_class_Map__instance_descriptors_offset

@targos
Copy link
Member

targos commented Jun 2, 2019

@nodejs/platform-ppc @nodejs/platform-s390 we have some segfaults in V8 tests: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=ppcle-ubuntu1404,v8test=v8test/ https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=rhel72-s390x,v8test=v8test/

@refack

This comment has been minimized.

Sign in to view
@miladfarca
Copy link
Contributor

miladfarca commented Jun 2, 2019 •
edited
Loading

s390 and ppc are segfaulting on some tests because of this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1632235, we have a solution but waiting on the original owner to get back to us on a question first.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jun 2, 2019
@targos

This comment has been minimized.

Sign in to view
@cjihrig
Copy link
Contributor

cjihrig commented Jun 2, 2019

@cjihrig could you PTAL at 9106789?

Sure thing.

@refack
Copy link
Contributor

refack commented Jun 2, 2019

😱 what happened to aix??

It get's that way from time to time.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs nodejs deleted a comment from nodejs-github-bot Jun 2, 2019
@refack

This comment has been minimized.

Sign in to view
@miladfarca
Copy link
Contributor

miladfarca commented Jun 2, 2019 •
edited
Loading

@refack the flaky test? might be an undefined behaviour where it passes or fails form time to time (due to this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1561072), will be looking into it using V8 master.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 3, 2019

@ryzokuken / @targos can you try cherry-picking in cjihrig@19d7b31 and cjihrig@9e50c0a.

@ryzokuken
Copy link
Contributor Author

ryzokuken commented Jun 3, 2019

@cjihrig @targos @refack fixed and done! PTAL. Making this PR ready for review. 🎉

@ryzokuken ryzokuken marked this pull request as ready for review June 3, 2019 15:17
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2019
@cjihrig @nodejs-ci
deps: V8: update postmortem metadata generation script
e8536ce 
Update postmortem metadata constants for V8 7.6 in Node.js.

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
f3af584 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
644b7f1 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
ff13269 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@cjihrig @nodejs-ci
deps: V8: update postmortem metadata generation script
6d50bae 
Update postmortem metadata constants for V8 7.6 in Node.js.

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
37a49d2 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
7f6a105 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
f79399c 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2019
@cjihrig @nodejs-ci
deps: V8: update postmortem metadata generation script
dd1a8cf 
Update postmortem metadata constants for V8 7.6 in Node.js.

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
98add5a 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@BethGriggs BethGriggs mentioned this pull request Sep 9, 2019
Merged
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@targos targos mentioned this pull request Jan 15, 2020
Closed
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@targos targos Awaiting requested review from targos

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ryzokuken ryzokuken

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.