fix v2.6.3 that did not send query params #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This have already been released to npm So no other choice then to merge |
LinusU
approved these changes
Sep 21, 2021
Member
LinusU
left a comment
LinusU
left a comment
There was a problem hiding this comment.
Thank you for the quick follow up on this! ❤️
gr2m
reviewed
Sep 21, 2021
| expect(json.url).to.equal('/inspect?month=2021-09') | ||
| }) | ||
| }) | ||
|
|
Collaborator
There was a problem hiding this comment.
thanks for putting in a test to avoid future regressions 💐
This explains the mystery of octokit/rest.js#114 and semantic-release/github#415
This was referenced Sep 21, 2021
4 tasks
This was referenced Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
closes #1300