Use new msgpack spec by default. #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| object into raw type in old msgpack spec, instead of bin type in new msgpack spec. | ||
|
|
||
| In case of packer, use UTF-8 always. Storing other than UTF-8 is not recommended. | ||
| You can unpack old msgpack formatk using ``raw=True`` option. |
|
|
||
| def test_unicode(): | ||
| assert unpackb(packb("foobar"), use_list=1) == b"foobar" | ||
| assert unpackb(packb(u"foobar"), use_list=1) == u"foobar" |
Contributor
There was a problem hiding this comment.
somehow makes more sense now. \o/
Contributor
There was a problem hiding this comment.
are there enough tests that check all "old msgpack" behaviour as well as all "new msgpack" behaviour (str, bytes, unicode).
esp. that using it the old way still works with the new code, when the right options are given.
borgbackup depends on old format and as people have that in their backup repositories, we can't change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99