Migrate to ConfigSpace 1.* #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to remove them
…/opt/configspace-1.0
motus
added
dependencies
bpkroth
reviewed
Jul 18, 2024
bpkroth
reviewed
Jul 18, 2024
bpkroth
reviewed
Jul 18, 2024
This was referenced Jul 19, 2024
Contributor
|
That ConfigSpace update to SMAC was merged, but they haven't cut a new version for us to pull in yet. |
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
bpkroth
reviewed
Jul 31, 2024
bpkroth
approved these changes
Jul 31, 2024
Contributor
bpkroth
left a comment
bpkroth
left a comment
There was a problem hiding this comment.
Mostly LGTM, just would like to get that quantization support back in asap.
Main remaining question is around the param.to_vector(param.to_vector(...)) transformation. Didn't quite look right, but maybe I'm missing something?
Member
Author
|
unit tests seem to break because of #826 - checking it now |
motus
force-pushed
the
sergiym/opt/configspace-1.0
branch
from
cc67ece to
96ad677
Compare
bpkroth
reviewed
Aug 1, 2024
Merged
bpkroth
added a commit
that referenced
this pull request
Aug 1, 2024
Splitting out from #802 to benefit other jobs as well.
motus
added a commit
that referenced
this pull request
Aug 6, 2024
This PR enables Python 3.12 in Windows environment and does not restrict Python version in the default environments on Windows and Linux. Note that although `mlos-3.12.yml` exists, its usage is still commented out in `linux.yml`, because Python 3.12 is still not available on GitHub CI. Issue #832 opened to track it P.S. Also, we now use a lighter `matplotlib-base` instead of `matplotlib` proper ~To be merged after #802~ --------- Co-authored-by: Brian Kroth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Notes:
Supersedes Bump configspace from 0.7.1 to 1.0.1 in /mlos_core #799Depends on upcoming SMAC3 release with SMAC3 #1124 merged in and a new release cut with it.Tests fail due to LlamaTune issue:Closes #727