Skip to content

Conversation

@bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Oct 2, 2024

Pull Request

Title

Combines container build steps to reduce devcontainer size substantially.


Description

Reduces container size from ~5.7GB to ~2.7GB by combining the following steps:

  • install conda (previously in a base image layer)
  • create the base mlos environment

This reduces the space substantially because conda's usual attempt to do hardlinks across environments is actually able to work.

The downside is that changes to base package level requirements require reinstalling all of conda again (i.e., the single large combined container layer is less cacheable).

Should help with issues like: Microsoft-CISL/sqlite-autotuning#7


Type of Change

  • 🔄 Refactor
  • Dev environment

Testing

  • time make devcontainer
  • "Rebuild devcontainer" inside VSCode
  • docker image ls to check the sizes

@bpkroth bpkroth added low priority Low-priority issue dev-env labels Oct 2, 2024
@bpkroth bpkroth marked this pull request as ready for review October 7, 2024 20:32
@bpkroth bpkroth requested a review from a team as a code owner October 7, 2024 20:32
@bpkroth bpkroth enabled auto-merge (squash) October 15, 2024 20:41
@bpkroth bpkroth merged commit d2738e7 into microsoft:main Oct 15, 2024
@bpkroth bpkroth deleted the simplify-devcontainer branch October 15, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-env low priority Low-priority issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants