Monkey patch Hyperparameter.sample_value() to support quantization
#833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
reviewed
Aug 6, 2024
| "type": "int", | ||
| "default": 2000000, | ||
| "range": [0, 1000000000], | ||
| "quantization": 1000000, |
Contributor
There was a problem hiding this comment.
Probably need tests to check this now, right?
Member
Author
There was a problem hiding this comment.
absolutely. I'll add a ton more unit tests to this PR shortly
bpkroth
reviewed
Aug 8, 2024
| else: | ||
| raise TypeError(f"Invalid Parameter Type: {tunable.type}") | ||
|
|
||
| if tunable.quantization: |
Contributor
There was a problem hiding this comment.
Suggested change
| if tunable.quantization: | |
| if tunable.quantization: | |
| # Temporary workaround to dropped quantization support in ConfigSpace 1.0 | |
| # See Also: https://github.com/automl/ConfigSpace/issues/390 |
bpkroth
requested changes
Aug 8, 2024
Contributor
bpkroth
left a comment
bpkroth
left a comment
There was a problem hiding this comment.
Waiting on tests and then let's merge this.
Member
Author
|
superseded by #835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental implementation of quantization of tunable parameters
Closes #803