bugfix: MySQL can round microseconds into the future causing scheduler to skip trials #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to skip trials. truncate microseconds downwards when scheduling new trials to fix that
motus
added
bug
…/storage/ts_round
bpkroth
reviewed
Jul 8, 2024
bpkroth
approved these changes
Jul 8, 2024
Contributor
bpkroth
left a comment
bpkroth
left a comment
There was a problem hiding this comment.
LGTM
Test failures seem unrelated
DelphianCalamity
pushed a commit
to DelphianCalamity/MLOS
that referenced
this pull request
Jul 12, 2024
…r to skip trials (microsoft#775) Solution: truncate microseconds of the current timestamp when scheduling new trials to be executed ASAP Closes microsoft#756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: truncate microseconds of the current timestamp when scheduling new trials to be executed ASAP
Closes #756