Skip to content

Allow no tunable configs for benchmarking #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
motus merged 6 commits into from
Feb 23, 2024
Merged

Allow no tunable configs for benchmarking #686

motus merged 6 commits into from
Feb 23, 2024

Conversation

@bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Feb 23, 2024 •
edited
Loading

Closes #613

  • add tests for data retrieval

@bpkroth bpkroth requested a review from a team as a code owner February 23, 2024 21:33
bpkroth
bpkroth commented Feb 23, 2024
View reviewed changes
@motus motus merged commit 32801b6 into microsoft:main Feb 23, 2024
@bpkroth bpkroth deleted the allow-no-tunable-configs-for-benchmarking branch February 26, 2024 16:07
@bpkroth bpkroth mentioned this pull request Feb 26, 2024
Merged
bpkroth added a commit that referenced this pull request Feb 26, 2024
@bpkroth
Add tests for config data retrieval for experiments with no tunables (#…
da6e2e5 
…689)

Additional test work for #686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@motus motus motus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storage schema doesn't allow an empty config

2 participants

@bpkroth @motus