CI tweak: use "release" event instead of "tag push" for pypi publishing #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
NOTE: The version bump currently in this PR was use for testing on my fork, but should be replaced with the one from #624 after it's merged. I don't think there's any point in publishing this particular patch version release - there's no functional change from the last one. |
motus
approved these changes
Jan 16, 2024
Member
motus
left a comment
motus
left a comment
There was a problem hiding this comment.
Looks good! I wonder if there is a way to store version in a single place?
Contributor
Author
It'd be nice, but no not really. We publish several packages out of the same repo, which is somewhat less common. That's in part what the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak on #626: instead of acting on tag push events, we only act on "release" events. This gives us a chance to fix bad tag pushes (which otherwise don't have much gated checking on them) prior to attempting to publish a version on pypi, which cannot be overwritten (only superseded).