Annotate example of using with null with good/bad #42944
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To clarify which example is good to follow
github-actions
bot
added
Content:JS
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-01-28 10:40:39) |
Clarified the usage of 'using' to allow null or undefined values, and improved examples for better understanding.
github-actions
bot
added
size/s
chrisdavidmills
approved these changes
Jan 28, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
Thanks @dontcallmedom, that change makes sense to me.
However, before merging, I had a look at the surrounding structure, fixed a grammar issue, and reordered the section to put the acquireResource() function out into its own code block.
Does that make sense to you — it is neither part of the good or bad code, right?
Contributor
Author
|
that makes a lot of sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add example-bad and example-good annotations to JS examples of
usingwith a null value.Motivation
To clarify which example is good to follow
Additional details
Related issues and pull requests