Skip to content

inputmode is supported on Firefox 79 for Android#6782

Merged
ddbeck merged 1 commit intomdn:masterfrom
makotokato:inputmode-79
Oct 15, 2020
Merged

inputmode is supported on Firefox 79 for Android#6782
ddbeck merged 1 commit intomdn:masterfrom
makotokato:inputmode-79

Conversation

@makotokato
Copy link
Contributor

@makotokato makotokato commented Sep 30, 2020

Shipped by https://bugzilla.mozilla.org/show_bug.cgi?id=1631681.

Also, inputmode preference should be same version of Firefox Desktop.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Sep 30, 2020
@ddbeck
Copy link
Contributor

ddbeck commented Oct 1, 2020

Thanks for this PR!

Also, inputmode preference should be same version of Firefox Desktop.

Do you want to include this change in this PR, @makotokato? I'd welcome that addition, or a follow-up. If you don't want to do it at all, we could open an issue to track that suggestion separately.

@foolip
Copy link
Contributor

foolip commented Oct 9, 2020

I think only remaining question here is missing flag data. Since we're definitely missing flag data all over the place, that seems quite OK to me. It will become consistent in 2 years when the existing flag data can be removed :)

@makotokato
Copy link
Contributor Author

makotokato commented Oct 12, 2020

Do you want to include this change in this PR, @makotokato? I'd welcome that addition, or a follow-up. If you don't want to do it at all, we could open an issue to track that suggestion separately.

Hmm, OK, this PR is Firefox Android 79 only. So I will update this PR.

Also, I will file another PR that is #6468 is incorrect.

@foolip foolip requested a review from ddbeck October 13, 2020 09:27
@ddbeck ddbeck mentioned this pull request Oct 15, 2020
Closed
ddbeck
ddbeck approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @makotokato!

Also, I wasn't entirely clear on what the situation was for Firefox on the desktop, so I opened #6921 to track that independently.

@ddbeck ddbeck merged commit 0084dc5 into mdn:master Oct 15, 2020
@makotokato makotokato deleted the inputmode-79 branch December 15, 2020 05:08
@queengooborg queengooborg mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@makotokato @ddbeck @foolip