Add Windows-specific CREATE_NO_WINDOW flag for test subprocesses #30879
Conversation
|
@sanchit122006 are you posting unreviewed tooling / AI output here? E.g.
This is not acceptable. I put the PR in draft state for now. Please cleanup and make sure all content (code and PR message are presented in a clean way). When you think the content is suitably consolidated so that it's worth putting valuable core developer time into, you can remove the draft status. |
|
@timhoffm Can you guide me to solve cl check's issue , |
What exactly is "command line check failing issue"? Are these failures in your local setup, e.g. pre-commit? Generally, a PR should only contain changes that are related to the PR. If for example, I very stongly assume the brew update change is independent of this PR. If you think a such a change is reaonable (or even prerequisite but independently meaningful) , please open a separate PR. It's much simpler to handle logically independent change separately. |
|
@timhoffm i am talking about these checks, can you guide me should i make new branch and PR on it, because 1 test is failing yet before has 2 failing checks then i edited and commit to fix macos check |
sanchit122006
force-pushed
the
dev-mat
branch
from
aee0fe2 to
b70e324
Compare
2 participants
This pull request makes the test subprocess helper a bit smarter on Windows to avoid spurious timeouts.
Added subprocess section in subprocess_run_for_testing function
Modified subprocess section
This change updates subprocess_run_for_testing so that, on Windows, it runs test subprocesses with the CREATE_NO_WINDOW flag. This prevents console windows from being created for every subprocess, which can contribute to the hanging and timeout behavior seen in the Windows test runs. The new behavior is guarded by sys.platform == "win32" and merges CREATE_NO_WINDOW with any existing creationflags, so non‑Windows platforms and callers that already pass creationflags keep their current behavior.
PR checklist