ENH: Add digits parameter to EngFormatter for significant figures #30827
+194
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed digits parameter for significant figure formatting, trim_zeros parameter to control trailing zeros, ensured mutual exclusion with places parameter, implemented boundary rollover (e.g., 999.95 → 1.000 k), added comprehensive tests for new functionality, and maintained backward compatibility. Should address matplotlib#30727
timhoffm
reviewed
Dec 9, 2025
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Please add a What's new entry
| "Cannot specify 'places' and 'digits'" | ||
| ) | ||
|
|
||
| if trim_zeros not in ("keep", "trim"): |
Member
There was a problem hiding this comment.
Is there a reason to not make trim_zeros a bool?
Author
There was a problem hiding this comment.
I initially chose string values to make the intent more explicit in code (e.g., trim_zeros="trim" reads clearly), but a bool would be simpler. I'm happy to change it to 'trim_zeros=False' to keep trailing zeros (i.e., default) and 'trim_zeros=True' to trim trailing zeros. Would you prefer this bool approach?
lib/matplotlib/ticker.py
Outdated
| """ | ||
| sign = 1 | ||
| fmt = "g" if self.places is None else f".{self.places:d}f" | ||
| fmt = "g" if self.places is None and self.digits is None else None |
Member
There was a problem hiding this comment.
Move to the block "# Determine format string based on digits or places" so that all the logic is in one place.
Member
|
Please fix the issues marked by ruff and mypy-stubtest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed digits parameter for significant figure formatting, trim_zeros parameter to control trailing zeros, ensured mutual exclusion with places parameter, implemented boundary rollover (e.g., 999.95 → 1.000 k), added comprehensive tests for new functionality, and maintained backward compatibility. Should address #30727
PR summary
PR checklist
Closes #30727