Fix: Change alpha application for RGBA from overwrite to multiply #30523
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LangQi99
changed the title
LangQi99
changed the title
Contributor
Author
|
Old Behavior pay attention to the bottom right New Behavior |
LangQi99
changed the title
github-actions
bot
removed
the
Documentation: examples
5 tasks
rcomer
reviewed
Nov 23, 2025
Member
rcomer
left a comment
rcomer
left a comment
There was a problem hiding this comment.
Thank you for your work on this @LangQi99 and sorry you did not get a response sooner. The fix looks right to me. However, this is a breaking change, as shown by the modified test. I do not think we can reasonably provide a deprecation pathway for this, but it should have an API change note.
| (im_rgb, | ||
| (scalar_alpha * array_alpha).reshape((ny, nx, 1))), | ||
| axis=-1), | ||
| interpolation_stage=intp_stage) |
Member
There was a problem hiding this comment.
This looks like a style-only change. Please revert.
Member
Contributor
Author
|
I'm not working on this currently. Feel free to close it. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #26092
Per community consensus in #26092, the behavior for RGBA inputs has been changed from overwriting to blending; the image's intrinsic alpha is now multiplied with the passed alpha value. This change unifies alpha handling for 2D, RGB, and RGBA images, making the behavior consistent and predictable.
PR checklist