feat: add qualified to @ValueMapping to inserting methods in the switch-default branch #3862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangyang9464
force-pushed
the
feature/3831-String2Enum-default-behavior
branch
5 times, most recently
from
9f37762 to
d4cb3bd
Compare
…ned methods in the switch-default branch Signed-off-by: TangYang <[email protected]>
tangyang9464
force-pushed
the
feature/3831-String2Enum-default-behavior
branch
from
d4cb3bd to
ad75854
Compare
Contributor
Author
|
@filiphr any viewpoints？ |
Member
|
I haven't had the time to go through this one yet. Will let you know once I get to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #3831
I added
qualifiedByandqualifiedByNameto@ValueMapping.MappingResolverImpl#getTargetAssignmentcannot handle this situation because the scenario of inserting method forswitch-defaultbranch is similar toLifecycleMethod, notMappingMethod, soDefaultValueMappingMethodResolveris added to handle collection methods. It is very similar toLifecycleMethodResolver.plz review. @filiphr