ignoreUnmappedSourceProperties does not propagate via @InheritConfiguration #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subclass. Test case
RichMacDonald
changed the title
Member
|
Thanks for the tests @RichMacDonald. We'll look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #3212 (reply in thread).
@BeanMapping(ignoreUnmappedSourceProperties = ...) does not propagate via @InheritConfiguration. So if a domain superclass object is mapped using ignoreUnmappedSourceProperties, any subclass mappings that use @InheritConfiguration have to redeclare the ignoreUnmappedSourceProperties.
Is this something that should always be true, or should it be an optional value, e.g., @InheritConfiguration(inheritIgnoreUnmappedSourceProperties=true)?
I am afraid I lack the understanding of the mapstruct implementation code to make the necessary code. However, I do have a failing test case that illustrates the concern.