Skip to content

Conversation

@jarlesat
Copy link

@jarlesat jarlesat commented Nov 16, 2022

Ignore unmapped "removers" in target classes. Fluent removers are generated by tools like OpenAPI generator, preventing the use of unmappedTargetPolicy=ERROR unless adding @Mapping(target='removeItem', ignore=true) for every single remover.

Fixes #3072

@jarlesat
Copy link
Author

Should this branch be rebased on main, as main now is version 1.7-SNAPSHOT? Anything else that should be done with it?

@filiphr
Copy link
Member

filiphr commented Nov 21, 2024

Sorry I have not reviewed this. @jarlesat it would indeed be good to rebase it on top of main.

Additionally, if you can move the test in org.mapstruct.ap.test.collection.remover it would be great. Now it us under bugs, but this is not a bug, it's a new feature.

@jarlesat
Copy link
Author

jarlesat commented Dec 3, 2024

Please let me know if there are anything more that should be done, test cases or anything. Maybe branch-name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MapStruct recognizes 'remove' method as property

2 participants