feat(remote): expose git_remote_oid_type
#7185
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If this is useful for you, I don't mind exposing it, but let's remote it from |
This would be useful for user to determine whether they want to proceed or bail further remote operations. Particularily useful for downstream libgit2 bindings and applications to experiment SHA256 support behind a runtime feature flag. For example, `cargo` could compile with sha256 support unconditionally, but reject SHA256 usage at runtime if the `-Zgit=sha256` nightly flag was not on. Cargo would leverage this new API to determine if users are trying to fetch a SHA256 remote repository and bail when needed before any fetches happen. Note that this is not gated behind `GIT_EXPERIMENTAL_SHA256` as the oid_type is sha1 and available always.
weihanglo
force-pushed
the
remote-oid-type
branch
from
d07bdec to
6893894
Compare
Contributor
Author
|
Thanks again for the review. The header got updated! BTW, mind asking when we plan to do a minor release? |
Member
🔜 This week or so, I think. There's a lot of good stuff ready to release! |
ethomson
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful for user to determine whether they want to proceed
or bail further remote operations. Particularily useful for downstream
libgit2 bindings and applications to experiment SHA256 support behind a
runtime feature flag.
For example,
cargocould compile with sha256 support unconditionally,but reject SHA256 usage at runtime if the
-Zgit=sha256nightly flagwas not on. Cargo would leverage this new API to determine if users are
trying to fetch a SHA256 remote repository and bail when needed before
any fetches happen.
If there is any better alternative than this to do runtime SHA256 support check for tools like Cargo, please share!
cc rust-lang/git2-rs#1090 and rust-lang/cargo#14942