Admin: Support multiple private keys in a file #8550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally we need to bulk-revoke private keys. The PEM format naturally allows for multiple private keys, so extend the admin tool to support multiple keys in a file for revoke-by-key and block-by-key.
aarongable
reviewed
Jan 9, 2026
Make spkiHashesFromPrivateKeys include which key failed parsing/hashing. Ensure updated functions have matching pluralization better variable name keyPEMs
There was a problem hiding this comment.
Pull request overview
This PR extends the admin tool to support multiple private keys in a single PEM file for bulk revocation and blocking operations. The PEM format naturally supports multiple entries, and this change enables more efficient bulk operations when multiple keys need to be revoked or blocked simultaneously.
Key changes:
- Refactored
privatekey.Loadto extract a newLoadDERfunction that can process individual PEM blocks - Updated
spkiHashesFromPrivateKeysandserialsFromPrivateKeysto iterate through all keys in a file - Added comprehensive test coverage for multiple keys with different encoding formats (PKCS8 ECDSA, PKCS8 RSA, PKCS1 RSA)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| privatekey/privatekey.go | Extracted LoadDER function to enable parsing individual PEM blocks; updated error messages to reference PEM block type instead of file path |
| cmd/admin/key.go | Refactored spkiHashesFromPrivateKeys to loop through multiple PEM blocks in a file and compute hashes for each key |
| cmd/admin/cert.go | Updated serialsFromPrivateKeys to fetch serials for multiple keys and aggregate results |
| cmd/admin/key_test.go | Enhanced test to validate multiple keys with different formats (PKCS8 ECDSA/RSA, PKCS1 RSA) |
| cmd/admin/cert_test.go | Updated test function name to reflect new plural function name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aarongable
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally we need to bulk-revoke private keys.
The PEM format naturally allows for multiple private keys, so extend the admin
tool to support multiple keys in a file for revoke-by-key and block-by-key.