Skip to content

Add support for fail_pr rule (watches) in scan pull requests #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eranturgeman merged 12 commits into from
Jun 25, 2025
Merged

Add support for fail_pr rule (watches) in scan pull requests #876

eranturgeman merged 12 commits into from
Jun 25, 2025

Conversation

@eranturgeman
Copy link
Collaborator

@eranturgeman eranturgeman commented Jun 17, 2025 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR adds support to the new fail_pull_request action that was introduced to P&W.
The new action is similar to fail_build, but is intended to PRs only and works as follows:
When a violation with fail_pull_request action applied to one of its rules is found - we fail PR build.

@eranturgeman eranturgeman requested review from attiasas and orz25 June 17, 2025 14:14
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Jun 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 17, 2025
orz25
orz25 reviewed Jun 18, 2025
View reviewed changes
orz25
orz25 reviewed Jun 18, 2025
View reviewed changes
orz25
orz25 reviewed Jun 18, 2025
View reviewed changes
@orz25
Copy link
Contributor

orz25 commented Jun 18, 2025

Can we add an e2e test with the following:

  1. Create a policy with a fail_pr rule action and a watch.
  2. Run frogbot scan.
  3. Validate the scan failed.

@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/frogbot into scan-pr-v…
b4e99ce 
…iolations-fail-pr-support

# Conflicts:
#	go.mod
#	go.sum
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 23, 2025
@eranturgeman eranturgeman requested review from orz25 and removed request for attiasas June 23, 2025 11:37
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 24, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 25, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit f880133 into jfrog:dev Jun 25, 2025
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orz25 orz25 Awaiting requested review from orz25

Assignees

No one assigned

Labels

new feature Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eranturgeman @orz25