Skip to content

Check in field visibility transformer test - union member error now fixed #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dondonz wants to merge 2 commits into
base: master
Choose a base branch
from
+69 −0
Open

Check in field visibility transformer test - union member error now fixed #4275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71835ab
Add sampler test with removed reference and union reference that remains
dondonz Mar 1, 2026
24696d9
Add the case where the non-union member is deleted
dondonz Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions src/test/groovy/graphql/schema/transform/FieldVisibilitySchemaTransformationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,4 +2010,73 @@ class FieldVisibilitySchemaTransformationTest extends Specification {
assertSchemaIsValid(restrictedSchema)
}

def "type is not deleted if remains a union member after its only private field path is removed"() {
given:
GraphQLSchema schema = TestUtil.schema("""

directive @private on FIELD_DEFINITION

type Query {
hello: String
createPizzaTopping(name: String!): PizzaToppingCreationPayload @private
toBeRemoved: PizzaToBeRemoved @private
}

union PizzaPolicy =
| PizzaTopping
| PizzaCrust
| PizzaDiscount
| PizzaAllergen

interface Payload {
success: Boolean!
}

type PizzaToppingCreationPayload implements Payload {
topping: PizzaTopping
success: Boolean!
}

type PizzaTopping {
id: ID
name: String
}

type PizzaCrust {
id: ID
name: String
}

type PizzaDiscount {
id: ID
percentage: Float
}

type PizzaAllergen {
id: ID
allergen: String
}

type PizzaToBeRemoved {
id: ID
}
""")

when:
GraphQLSchema restrictedSchema = visibilitySchemaTransformation.apply(schema)

then: "the private field paths are removed"
(restrictedSchema.getType("Query") as GraphQLObjectType).getFieldDefinition("createPizzaTopping") == null
restrictedSchema.getType("PizzaToppingCreationPayload") == null

and: "PizzaTopping is still present because it is reachable as a union member of the public PizzaPolicy"
restrictedSchema.getType("PizzaTopping") != null

and: "Types with no reference at all (not a union member) is correctly removed"
restrictedSchema.getType("PizzaToBeRemoved") == null

and: "the resulting schema is valid - previously this would produce an invalid schema"
assertSchemaIsValid(restrictedSchema)
}

}
Loading