Skip to content

Remove incorrect @Nullable from GraphQLSchema.getCodeRegistry() #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 1 commit into from
Feb 15, 2026
Merged

Remove incorrect @Nullable from GraphQLSchema.getCodeRegistry() #4247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/graphql/schema/GraphQLSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@ public class GraphQLSchema {
private final @Nullable SchemaDefinition definition;
private final ImmutableList<SchemaExtensionDefinition> extensionDefinitions;
private final @Nullable String description;
private final @Nullable GraphQLCodeRegistry codeRegistry;
private final GraphQLCodeRegistry codeRegistry;

private final ImmutableMap<String, GraphQLNamedType> typeMap;
private final ImmutableMap<String, ImmutableList<GraphQLObjectType>> interfaceNameToObjectTypes;
private final ImmutableMap<String, ImmutableList<String>> interfaceNameToObjectTypeNames;

/*
* This constructs partial GraphQL schema object which has the schema (query / mutation / subscription) trees
* in it but it does not have the collected types, code registry nor the type references replaced
* in it but it does not have the collected types, the correct code registry nor the type references replaced
*
* But it can be traversed to discover all that and filled out later via another constructor.
*
Expand All @@ -102,7 +102,7 @@ private GraphQLSchema(Builder builder) {
this.extensionDefinitions = nonNullCopyOf(builder.extensionDefinitions);
this.description = builder.description;

this.codeRegistry = null;
this.codeRegistry = builder.codeRegistry;
this.typeMap = ImmutableKit.emptyMap();
this.interfaceNameToObjectTypes = ImmutableKit.emptyMap();
this.interfaceNameToObjectTypeNames = ImmutableKit.emptyMap();
Expand Down Expand Up @@ -254,7 +254,7 @@ private static ImmutableMap<String, ImmutableList<String>> buildInterfacesToObje
return map.build();
}

public @Nullable GraphQLCodeRegistry getCodeRegistry() {
public GraphQLCodeRegistry getCodeRegistry() {
return codeRegistry;
}

Expand Down
Loading