-
Notifications
You must be signed in to change notification settings - Fork 1.1k
GQLGW-5297-optimise-incremental-part-execution-for-defer-requests #4174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andimarek
merged 6 commits into
graphql-java:master
from
llin2:GQLGW-5297-optimise-incremental-part-execution-for-defer-requests
Nov 30, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dd8313b
GQLGW-5297-optimise-incremental-part-execution-for-defer-requests
llin2 7e8d69a
GQLGW-666-do-not-start-on-separate-thread
llin2 a5c458e
GQLGW-666-move-start-to-after-initial-fields-resolve-with-info
llin2 50169f0
GQLGW-5297-assert-on-result-and-remove-redundant-call
llin2 0f365b5
GQLGW-5297-add-unusual-config
llin2 18207de
GQLGW-5297-remove-start-defer-calls
llin2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/main/java/graphql/execution/incremental/IncrementalExecutionContextKeys.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package graphql.execution.incremental; | ||
|
|
||
|
|
||
| import graphql.Internal; | ||
| import org.jspecify.annotations.NullMarked; | ||
|
|
||
| /** | ||
| * GraphQLContext keys for controlling incremental execution behavior. | ||
| */ | ||
| @Internal | ||
| @NullMarked | ||
| public final class IncrementalExecutionContextKeys { | ||
| private IncrementalExecutionContextKeys() { | ||
| } | ||
|
|
||
| /** | ||
| * Enables eager start of @defer processing so defered work runs before the initial result is computed. | ||
| * Defaults to false. | ||
| * <p> | ||
| * Expects a boolean value. | ||
| */ | ||
| public static final String ENABLE_EAGER_DEFER_START = "__GJ_enable_eager_defer_start"; | ||
|
|
||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create a new entry in the unusual config - lets put it in
graphql.GraphQLUnusualConfiguration.IncrementalSupportConfig