Conversation
google-cla
bot
added
the
cla: yes
AVaksman
approved these changes
Apr 27, 2021
IlyaFaer
reviewed
Apr 28, 2021
test/test_suite.py
Outdated
|
|
||
| @pytest.mark.skip("Spanner doesn't support auto increment") | ||
| def test_autoclose_on_insert(self): | ||
| pass |
Contributor
There was a problem hiding this comment.
This test is flaky, it sometime passes. That means it can be fixed instead of skipping.
Contributor
Author
There was a problem hiding this comment.
I have tried multiple times, but it failed every time, the test is related to auto increment which spanner doesn't support. To pass this need to fill id manually which break the meaning of test.
Contributor
Author
There was a problem hiding this comment.
I don't think its flaky as in create table sql define NOT NULL to id column. CREATE TABLE autoinc_pk (id INT64 NOT NULL, data STRING(50)\n) PRIMARY KEY (id). Hence override the test and also enable and override the other related advance test.
HemangChothani
changed the title
HemangChothani
changed the title
…n-spanner-sqlalchemy into autoincrement_on_insert
larkee
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.