Conversation
google-cla
bot
added
the
cla: yes
Contributor
Author
|
All the tests passes once googleapis/python-spanner#290 PR merged. |
…n-spanner-sqlalchemy into numeric_compliance_test
…n-spanner-sqlalchemy into numeric_compliance_test
Contributor
|
Tests look good to me. LGTM. |
vi3k6i5
approved these changes
May 4, 2021
Contributor
vi3k6i5
left a comment
vi3k6i5
left a comment
There was a problem hiding this comment.
Test changes look good to me. Please wait for Skylar's approval before merging.
larkee
reviewed
May 10, 2021
Contributor
Author
|
Failed test will be resolved by PR #62 |
larkee
reviewed
May 12, 2021
test/test_suite.py
Outdated
| of 38 and scale of 9. | ||
| """ | ||
| self._do_test( | ||
| Numeric(precision=18, scale=12), |
Contributor
There was a problem hiding this comment.
We are overriding a number of tests because Spanner does not support scale>9. But these tests still uses Numeric with scale=12 or scale=14. I think it makes sense to change these Numerics to use scale=9. WDYT?
larkee
approved these changes
May 12, 2021
…n-spanner-sqlalchemy into numeric_compliance_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.