fix: casing mismatch between the google api and python sdk#2116
Open
strangeleo02 wants to merge 3 commits intogoogleapis:mainfrom
Open
fix: casing mismatch between the google api and python sdk#2116strangeleo02 wants to merge 3 commits intogoogleapis:mainfrom
strangeleo02 wants to merge 3 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Added PropertyInfo/Field aliases to map snake_case to camelCase. Added test_persistence.py to verify field mapping.
strangeleo02
force-pushed
the
fix-interactions-state
branch
from
b8dc1dc to
06e66bd
Compare
strangeleo02
changed the title
Author
|
@MarkDaoust can you look into this?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix casing mismatch in Interactions module
Issue: #2112
Problem:
The SDK used
snake_casewhile the API expected/returnedcamelCase. This causedprevious_interaction_idto be ignored in requests and returned asNonein responses.Solution:
Implemented bidirectional aliasing to sync the naming conventions:
PropertyInfo(alias="...")tointeraction_create_params.pyandgeneration_config_param.py.Field(alias="...")tointeraction.pyandusage.py.test_persistence.pyto verify that state is correctly mapped and preserved.Closes #2112