Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: remove use of old external mock#676

Closed
a-detiste wants to merge 2 commits intogoogleapis:mainfrom
a-detiste:main
Closed

fix: remove use of old external mock#676
a-detiste wants to merge 2 commits intogoogleapis:mainfrom
a-detiste:main

Conversation

@a-detiste
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue: there were various attempts before that got stuck by lack of CLA
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@a-detiste a-detiste requested a review from a team as a code owner July 6, 2024 21:50
@a-detiste a-detiste requested a review from a team July 6, 2024 21:50
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 6, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 6, 2024
@parthea parthea changed the title new attempt at remove use of old external mock fix: remove use of old external mock Jul 29, 2024
@a-detiste
Copy link
Author

This looks a tad too early as Py3.7 is still currently supported

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants