feat: update V4 signature to pass conformance tests#114
Merged
JesseLovelace merged 14 commits intomasterfrom Feb 5, 2020
Merged
feat: update V4 signature to pass conformance tests#114JesseLovelace merged 14 commits intomasterfrom
JesseLovelace merged 14 commits intomasterfrom
Conversation
googlebot
added
the
cla: yes
frankyn
suggested changes
Feb 4, 2020
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Nicely done, overall LGTM I have one question before approving.
| HOST_NAME, | ||
| PATH_STYLE, | ||
| VIRTUAL_HOSTED_STYLE, | ||
| BUCKET_BOUND_HOST_NAME, |
Contributor
There was a problem hiding this comment.
Jesse, I want to confirm that HOST_NAME can't be in the same way as BUCKET_BOUND_HOST_NAME. Is this accurate?
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
============================================
+ Coverage 63.3% 63.73% +0.42%
- Complexity 528 539 +11
============================================
Files 30 30
Lines 4720 4740 +20
Branches 450 455 +5
============================================
+ Hits 2988 3021 +33
+ Misses 1571 1564 -7
+ Partials 161 155 -6
Continue to review full report at Codecov.
|
JesseLovelace
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the conformance tests and adds the consistency changes necessary to make them pass, as per #84 and #85