Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: Add support for batching configuration#977

Merged
losalex merged 11 commits intomainfrom
losalex/feat-903
Jan 11, 2023
Merged

feat: Add support for batching configuration#977
losalex merged 11 commits intomainfrom
losalex/feat-903

Conversation

@losalex
Copy link
Contributor

@losalex losalex commented Jan 10, 2023

Fixes #903 ☕️

@losalex losalex requested review from a team January 10, 2023 20:45
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: logging Issues related to the googleapis/java-logging-logback API. labels Jan 10, 2023
losalex and others added 10 commits January 10, 2023 12:46
@losalex
Add space
d33d6ee
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
8189223 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'losalex/feat-903' of https://github.com/googleapis/java…
46a6c9a 
…-logging-logback into losalex/feat-903
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
ddfcf63 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'losalex/feat-903' of https://github.com/googleapis/java…
cb78c87 
…-logging-logback into losalex/feat-903
@losalex
Remove redundant HTML appender tag
e61565f
@losalex
Merge branch 'losalex/feat-903' of https://github.com/googleapis/java…
c5fba67 
…-logging-logback into losalex/feat-903
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
ae5166a 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@losalex
Add failing dependencies
695039f
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
9610387 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
minherz
minherz reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to avoid introducing more dependencies or stream-like initialization.
The code will be cleaner if the configuration hides implementation details i.e. typing or GAX dependencies.

@losalex
Copy link
Contributor Author

losalex commented Jan 11, 2023

I would suggest to avoid introducing more dependencies or stream-like initialization. The code will be cleaner if the configuration hides implementation details i.e. typing or GAX dependencies.

Is the only problem using LimitExceededBehavior (which is the only GAX type exposed)?

daniel-sanche
daniel-sanche approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@losalex
Copy link
Contributor Author

losalex commented Jan 11, 2023 •
edited
Loading

I would suggest to avoid introducing more dependencies or stream-like initialization. The code will be cleaner if the configuration hides implementation details i.e. typing or GAX dependencies.

Is the only problem using LimitExceededBehavior (which is the only GAX type exposed)?

Talked offline - opened 1247 to implement batch settings abstraction layer in java-logging which later can be leveraged in java-logback as well

@losalex losalex merged commit afbe09c into main Jan 11, 2023
@losalex losalex deleted the losalex/feat-903 branch January 11, 2023 22:26
@release-please release-please bot mentioned this pull request Jan 11, 2023
Merged
@meredithslota meredithslota mentioned this pull request May 31, 2023
Open
@release-please release-please bot mentioned this pull request Jan 10, 2024
Closed
@release-please release-please bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@minherz minherz minherz left review comments

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daniel-sanche daniel-sanche

Labels

api: logging Issues related to the googleapis/java-logging-logback API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for batching configuration

3 participants

@losalex @daniel-sanche @minherz