Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: Add support for partialSuccess#908

Merged
losalex merged 2 commits intomainfrom
losalex/feat-batching-partialSuccess
Oct 31, 2022
Merged

feat: Add support for partialSuccess#908
losalex merged 2 commits intomainfrom
losalex/feat-batching-partialSuccess

Conversation

@losalex
Copy link
Contributor

@losalex losalex commented Oct 31, 2022

Fixes #598 ☕️

@losalex losalex requested review from a team October 31, 2022 23:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging-logback API. labels Oct 31, 2022
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be useful if this flag could be set on a specific log entry too though, along with global configuration

@losalex losalex merged commit 1699f70 into main Oct 31, 2022
@losalex losalex deleted the losalex/feat-batching-partialSuccess branch October 31, 2022 23:36
@losalex
Copy link
Contributor Author

losalex commented Oct 31, 2022

LGTM. It might be useful if this flag could be set on a specific log entry too though, along with global configuration

Thank you @daniel-sanche! Apparently, there is no such ability today, but perhaps we can think about it in the future

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/java-logging-logback API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants