feat: Add ability to specify RetryOptions and BigQueryRetryConfig when create job and waitFor#3398
Merged
PhongChuong merged 12 commits intomainfrom Jul 24, 2024
Merged
feat: Add ability to specify RetryOptions and BigQueryRetryConfig when create job and waitFor#3398PhongChuong merged 12 commits intomainfrom
PhongChuong merged 12 commits intomainfrom
Conversation
product-auto-label
bot
added
size: l
shollyman
reviewed
Jul 23, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
Generally looks good, just a question about this new configurability in the face of non-query jobs.
shollyman
approved these changes
Jul 24, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
Thanks for the clarifications, looks good!
Contributor
Author
|
Thanks for the review. |
This was referenced Jul 30, 2024
lqiu96
pushed a commit
that referenced
this pull request
Aug 28, 2024
…n create job and waitFor (#3398) * feat: initial implementation of customizable BigQueryRetryConfig * Add unit and integration tests * Fix lint issues * Revert unintentional changes to testQueryStatistics in ITBigQueryTest * Revert unintentional changes to testQueryStatistics in ITBigQueryTest * Revert unintentional changes to testQueryStatistics in ITBigQueryTest * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add additional comments to Job.waitFor() for BigQueryRetryConfig --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to specify RetryOptions and BigQueryRetryConfig when creating jobs. The RetryOptions and BigQueryRetryConfig are embedded in JobOptions so the BigQuery API interface does not change. This can be extended to other options such as DatasetListOption, DatasetOption, etc. Those options will be added in a future PR as needed.
In addition:
This PR also overloads the job.waitFor() method to allow users to specify BigQueryRetryConfig.
This PR also has a minor refactor to JobTest.java.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #3399 ☕️