Remove '_implicit_environ'#979
Merged
tseaver merged 11 commits intogoogleapis:masterfrom Jul 13, 2015
tseaver:944-remove__implicit_environ
Merged
Remove '_implicit_environ'#979tseaver merged 11 commits intogoogleapis:masterfrom tseaver:944-remove__implicit_environ
tseaver merged 11 commits intogoogleapis:masterfrom
tseaver:944-remove__implicit_environ
Conversation
googlebot
added
the
cla: yes
8 tasks
Contributor
|
Ping me here when #978 is in. |
Contributor
Author
Contributor
Author
Update batch/transaction to push themselves onto client's stack, rather than batches. Updated API-invoking methods to take 'client', rather than 'connection', falling back to the client held by self. See #944.
Also remove symbols imported for conveniences from '_implicit_environ'.
Contributor
Author
Contributor
Author
|
I'm not as fussy as you about the commit history -- if you'd like, I can just squash the whole PR into a single commit. |
Contributor
|
I'm not that fussy. I think re-committing the "Update batch/transaction/query to hold client." commit only to remove those changes later is a bit silly, but not worth arguing over. (Just re-read my comment yesterday, noticed "moral" instead of "normal", unintentionally a bit dramatic by me! Reviews from phone will do that to you.) Your " Code LGTM. Feel free to merge. |
parthea
added a commit
that referenced
this pull request
Sep 11, 2025
Co-authored-by: Lingqing Gan <[email protected]>
parthea
added a commit
that referenced
this pull request
Sep 16, 2025
Co-authored-by: Lingqing Gan <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* fix(deps): require google-cloud-audit-log >= 0.3.1 * update constraints-3.8.txt * remove dev
parthea
added a commit
that referenced
this pull request
Nov 25, 2025
* fix(deps): require google-cloud-audit-log >= 0.3.1 * update constraints-3.8.txt * remove dev
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
… RESOURCE_EXHAUSTD (#979) * fix: Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD PiperOrigin-RevId: 557935020 Source-Link: googleapis/googleapis@38e1f31 Source-Link: googleapis/googleapis-gen@5bbe39d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJiZTM5ZDM3MjE4YTQyMGIyMzY4YzM3NTQxZGU1ODg3ZGI3ZDZhZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #978 as a base.
Final cleanup for #944.