Skip to content

Adjust anchor scroll in docs to show actual line.#1900

Merged
daspecster merged 1 commit intogoogleapis:masterfrom
daspecster:fix-anchor-link-scroll
Jun 27, 2016
Merged

Adjust anchor scroll in docs to show actual line.#1900
daspecster merged 1 commit intogoogleapis:masterfrom
daspecster:fix-anchor-link-scroll

Conversation

@daspecster
Copy link
Contributor

The fixed header isn't accounted for when scrolling to anchor points so the original anchor text is obscured.

I would actually prefer to remove the fixed header instead of merging this PR. If it's ok to remove the fixed header let me know and I can do that instead!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2016
@tseaver
Copy link
Contributor

tseaver commented Jun 27, 2016

LGTM

@daspecster daspecster merged commit b0558ba into googleapis:master Jun 27, 2016
@daspecster daspecster deleted the fix-anchor-link-scroll branch June 27, 2016 15:06
@tseaver tseaver mentioned this pull request Jun 29, 2016
parthea added a commit that referenced this pull request Mar 2, 2026
[A recent
change](googleapis/google-auth-library-python@36ecb1d#diff-4762e5cf4088fa77af8bf63829f842548a4cad6e76be593786876e314807cd8f)
added an internal _refresh_token method to some credentials files.

Parts of the codebase were already using `_refresh_token` as an internal
variable, holding a token value

This causes some inconsistencies in the codebase, where it's not always
clear if `_refresh_token` is referring to an action or an object

It was also causing complications in internal code that depended on
_refresh_token objects

This PR renames the methods to `_perform_refresh_token`, to avoid the
duplicate naming

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Chalmer Lowe <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants