_LoggingAPI: impedance matching with JSON API.#1892
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Jun 23, 2016
tseaver:logging-gax_cleanups
Merged
_LoggingAPI: impedance matching with JSON API.#1892tseaver merged 1 commit intogoogleapis:masterfrom tseaver:logging-gax_cleanups
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:logging-gax_cleanups
Conversation
tseaver
added
type: bug
googlebot
added
the
cla: yes
Contributor
Author
|
@daspecster Rebased after merge of #1888. PTAL. |
JSON APIs return mappings using 'camelCase' keys, while the generated protobuf attributes 'use_underscores'.
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
parthea
added a commit
that referenced
this pull request
Mar 2, 2026
Also update the `docs` session to 3.10 to match the Python GAPIC code generator used to generate Cloud Client libraries: https://github.com/googleapis/gapic-generator-python/blob/d20dd2876fbf8c35f6a994639864815b0d7608ab/gapic/templates/noxfile.py.j2#L360-L361 Also update black to 23.7.0 to resolve the following stack trace ``` nox > python -m pip install flake8 flake8-import-order docutils click==8.0.4 black==19.3b0 nox > python -m pip install -e . nox > black --check google tests tests_async noxfile.py setup.py docs/conf.py Traceback (most recent call last): File "/tmpfs/src/github/google-auth-library-python/.nox/lint/bin/black", line 8, in <module> sys.exit(patched_main()) ~~~~~~~~~~~~^^ File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/black.py", line 3754, in patched_main main() ~~~~^^ File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/click/core.py", line 1128, in __call__ return self.main(*args, **kwargs) ~~~~~~~~~^^^^^^^^^^^^^^^^^ File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/click/core.py", line 1053, in main rv = self.invoke(ctx) File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/click/core.py", line 1395, in invoke return ctx.invoke(self.callback, **ctx.params) ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/click/core.py", line 754, in invoke return __callback(*args, **kwargs) File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/click/decorators.py", line 26, in new_func return f(get_current_context(), *args, **kwargs) File "/tmpfs/src/github/google-auth-library-python/.nox/lint/lib/python3.14/site-packages/black.py", line 434, in main loop = asyncio.get_event_loop() File "/usr/local/lib/python3.14/asyncio/events.py", line 715, in get_event_loop raise RuntimeError('There is no current event loop in thread %r.' % threading.current_thread().name) RuntimeError: There is no current event loop in thread 'MainThread'. nox > Command black --check google tests tests_async noxfile.py setup.py docs/conf.py failed with exit code 1 ``` This PR also fixes the coverage presubmit to append the coverage check to run across python runtimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #1888 as a base.