Skip to content

WAG: try to preinstall 'grpcio' on appveyor.#1877

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:appveyor-grpc-issue-6939-wag
Jun 20, 2016
Merged

WAG: try to preinstall 'grpcio' on appveyor.#1877
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:appveyor-grpc-issue-6939-wag

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 20, 2016

See #1863.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2016
@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

Sorry for n00b question, what is WAG?

@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

LGTM

@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2016

@dhermes "WAG" -> "wild-assed guess".

@tseaver tseaver merged commit fd8ff5a into googleapis:master Jun 20, 2016
@tseaver tseaver deleted the appveyor-grpc-issue-6939-wag branch June 20, 2016 23:19
@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2016

Now we cross our fingers and think Good Thoughts(tm).

@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2016

Horsefeathers. My cmd.exe fu has withered away like the Marxist state.

@dhermes
Copy link
Contributor

dhermes commented Jun 21, 2016

@dhermes
Copy link
Contributor

dhermes commented Jun 21, 2016

%CMD_IN_ENV% if "%INSTALL_GRPC%"=="1" (pip install grpcio)
Using default MSVC build environment for 64 bit architecture
Executing: if ""=="1" (pip install grpcio)
'if' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

If we drop testing Python 2.6 on Appveyor, I think we can get away with installing grpcio and the gax-* packages unconditionally.

@dhermes
Copy link
Contributor

dhermes commented Jun 21, 2016

👍 Dropping Windows Python 2.6 testing is A-OK with me.

@tseaver tseaver mentioned this pull request Jun 29, 2016
parthea pushed a commit that referenced this pull request Mar 2, 2026
…nction (#1877)

get_client_ssl_credentials had a bug that defaulted the cert path to
CERTIFICATE_CONFIGURATION_DEFAULT_PATH if not explicitly specified. The
correct behavior should be to delegate the lookup logic to
"_get_workload_cert_and_key" which also takes into account the cert
config path set by the env var GOOGLE_API_CERTIFICATE_CONFIG.

---------

Co-authored-by: Daniel Sanche <[email protected]>
parthea pushed a commit that referenced this pull request Mar 2, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest
<details><summary>google-auth: 2.44.0</summary>

##
[2.44.0](googleapis/google-auth-library-python@v2.43.0...v2.44.0)
(2025-12-12)

### Features

* MDS connections use mTLS (#1856)
([0387bb95](googleapis/google-auth-library-python@0387bb95))

* support Python 3.14 (#1822)
([0f7097e7](googleapis/google-auth-library-python@0f7097e7))

* add ecdsa p-384 support (#1872)
([39c381a5](googleapis/google-auth-library-python@39c381a5))

* Add shlex to correctly parse executable commands with spaces (#1855)
([cf6fc3cc](googleapis/google-auth-library-python@cf6fc3cc))

* Implement token revocation in STS client and add revoke() metho…
(#1849)
([d5638986](googleapis/google-auth-library-python@d5638986))

### Bug Fixes

* Add temporary patch to workload cert logic to accomodate Cloud Run
mis-configuration (#1880)
([78de7907](googleapis/google-auth-library-python@78de7907))

* Delegate workload cert and key default lookup to helper function
(#1877)
([b0993c7e](googleapis/google-auth-library-python@b0993c7e))

* Use public refresh method for source credentials in
ImpersonatedCredentials (#1884)
([e0c3296f](googleapis/google-auth-library-python@e0c3296f))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. packaging testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants