Remove TableInfo hierarchy, add TableType hierarchy#600
Remove TableInfo hierarchy, add TableType hierarchy#600aozarov merged 5 commits intogoogleapis:masterfrom
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
2 BigQuery lint errors unrelated to this PR: gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/WriteChannelConfigurationTest.java:50: error: Line is longer than 100 characters (found 113). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Took a first pass, looks good! Just some minor comments from me. |
3474f3b to
04fbf41
Compare
04fbf41 to
931b4d3
Compare
|
Looks good, just one new lint error: Aside from this PR, I think it'd be cool if we figured out some way to link the snippets in the READMEs to code we could test in Travis (something like the snippets here: https://cloud.google.com/appengine/docs/java/gettingstarted/ui_and_code). That way we'd always know our snippets are up to date after changes. But in lieu of that for now, it'd be good to test that the snippets work when this is about to get merged in, or when the info and functional objects get merged (if that's going to happen sooner rather than later). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
fixed
I totally agree but this is not easy to do. Snippets that we have now are simple end-to-end usage showcases (e.g. update a blob if it exists or create it if not). On the other hand our examples are more complex and command-line oriented to show the usage of each single functionality. Snippets could be part of IT tests but they will need changes anyway: asserts, data definitions, etc. What we could do is creating a |
|
Renamed to |
4ee4554 to
085903a
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This PR removes
TableInfohierarchy and replaces it with a hierarchy onTableType. This change is needed to make functionalTableextendTableInfo. Notes:DefaultTableType,ExternalTableTypeorViewType) must be provided to create aJobInfoobject.ExternalDataConfigurationhas been removed in favore ofExternalTableTypewhich is also used for defining external table sources inQueryJobConfiguration.