feat: Support ID token for SAs in other than the default universe domain#2921
Merged
amanda-tarafa merged 2 commits intogoogleapis:mainfrom Jan 28, 2025
Merged
feat: Support ID token for SAs in other than the default universe domain#2921amanda-tarafa merged 2 commits intogoogleapis:mainfrom
amanda-tarafa merged 2 commits intogoogleapis:mainfrom
Conversation
These are truly general purpose requests to the IAM Service Credential API, we just happened to be using them for impersonation only.
jskeet
reviewed
Jan 28, 2025
| TokenRefreshManager tokenRefreshManager = null; | ||
| tokenRefreshManager = new TokenRefreshManager( | ||
| ct => RefreshOidcTokenAsync(tokenRefreshManager, options, ct), Clock, Logger); | ||
| ct => RefreshDefultUniverseOidcTokenAsync(tokenRefreshManager, options, ct), Clock, Logger); |
| public static TheoryData<string, string, string, string> OidcData => new TheoryData<string, string, string, string> | ||
| { | ||
| // universe domain, token URL, SA id, expected OIDC URL | ||
| { null, "http://will.be.ignored", "MyId", "http://will.be.ignored/" }, |
Collaborator
There was a problem hiding this comment.
"will.be.ignored" sounds wrong if we're later asserting that we've actually made a call to it. (I'd expected tests which demonstrated the more radically different paths taken here, but maybe I just don't understand.)
amanda-tarafa
force-pushed
the
id-token
branch
from
cf0e35a to
f2f4599
Compare
amanda-tarafa
commented
Jan 28, 2025
Contributor
Author
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
@jskeet comments adressed and squashed in last commit.
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Jun 6, 2025
Features: - googleapis#2950 Support ExternalAccountAuthorizedUserCredential - googleapis#2921 Support ID token for SAs in other than the default universe domain
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Jun 9, 2025
Features: - googleapis#2950 Support ExternalAccountAuthorizedUserCredential - googleapis#2921 Support ID token for SAs in other than the default universe domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes b/333097506