Update to 2024-06-21 google3 version#367
Merged
jmr merged 3 commits intogoogle:masterfrom Jun 29, 2024
Merged
Conversation
* Replace S2Testing::Random, which was based on random(3), with new s2random:: namespace, based on abseil-cpp's random library. This removes the use of global state. * Use int64_t instead of int64, etc. * constexpr fixes * Reworked S2ClosestEdgeQuery
* Replace S2Testing::Random, which was based on random(3), with new s2random:: namespace, based on abseil-cpp's random library. This removes the use of global state. * Use int64_t instead of int64, etc. * constexpr fixes * Reworked S2ClosestEdgeQuery * Remove some old SWIG workarounds. Merge branch 'google3-update-2024-06-21' into update-2024-06-21
This SWIG macro controls whether `int64_t` is `long long` or `long`. Previously, this was defined for all 64-bit platforms. MacOS and Windows use `long long` for `int64_t`, while Linux and most other Unices use `long`. This has only been tested with Linux, but conditional definitions like this are what I'm finding in web searches.
Merged
jmr
pushed a commit
that referenced
this pull request
Jul 5, 2024
PR #367 forgot to adjust a few types which are under the IS_BIG_ENDIAN define.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new s2random:: namespace, based on abseil-cpp's random library.
This removes the use of global state.