Add ability to create Python wheels#313
Conversation
… policies to remove warnings about using deprecated default binding name; Fix broken unit tests
…n instructions for building Python wheel
…uilding Python wheel
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jmr
left a comment
jmr
left a comment
There was a problem hiding this comment.
Thanks. This is requested a lot and I never had time to look into it.
Note that we plan to delete the swig wrappers soon and use pybind11 or pyclif with a more Pythonic API.
…ect source URL and license as well as add minimal classifiers; Edit README to be less repetitive re. handling OpenSSL location
setup.cfg
Outdated
| @@ -0,0 +1,22 @@ | |||
| [metadata] | |||
| name = s2geometry | |||
| version = 0.10.0 | |||
There was a problem hiding this comment.
What's the allowed format of version? Can this be 0.11.dev or prerelease or something?
0.10 has already been released, so it's probably not great if we end up with loads of variants built at different times claiming to be 0.10.0.
There was a problem hiding this comment.
I updated this to a PEP 440-compliant pre-release version number.
…in master does not correspond to already released version 0.10.0
|
@jmr Let me know if there's anything more to be done on this PR and if there is anyway that I can help with the migration from SWIG. Thanks! |
|
Thanks! I'll let you know when we have something in the way of a SWIG replacement. |
2 participants
This pull request enables the creation of Python wheels via integration with CMake. This also changes the name of the Python library from
pywraps2to the more ergonomics2geometry.