Merged
Conversation
* Require C++14 instead of C++11 (abseil-cpp requires it now) * Require googletest >= 1.10 (for gmock) * Location is now specified with -DGOOGLETEST_ROOT * New classes: * S2CellIterator * S2CellIteratorJoin * S2Coder * New StableAngle function * Delete many deprecated functions * S2Point is now a different class from Vector3_d, not a typedef for it
Member
Author
MBkkt
reviewed
Jan 6, 2023
Contributor
MBkkt
left a comment
MBkkt
left a comment
There was a problem hiding this comment.
In general thanks for updating
MBkkt
reviewed
Jan 6, 2023
MBkkt
reviewed
Jan 10, 2023
MBkkt
reviewed
Jan 10, 2023
jmr
commented
Jan 10, 2023
This is a C++17 feature, and we want to remain C++14-compatible. (However, this worked for me with g++ and the default of CMAKE_CXX_STANDARD=14.)
jmr
force-pushed
the
update-2023-01-04
branch
from
be8a56d to
f9f2ea1
Compare
Member
Author
MBkkt
reviewed
Jan 11, 2023
Contributor
MBkkt
left a comment
MBkkt
left a comment
There was a problem hiding this comment.
Is it build and passed tests now?
Or maybe you need I try it locally?
Member
Author
Yes. |
This was referenced Jan 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-DGOOGLETEST_ROOTS2CellIteratorS2CellIteratorJoinS2CoderStableAnglefunctionS2Pointis now a different class fromVector3_d,not atypedeffor itFixes #259, #280, #295.