Enable user to override default diff -M arg#1551
Enable user to override default diff -M arg#1551Byron merged 4 commits intogitpython-developers:mainfrom
Conversation
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
That looks simple enough, thanks a lot!
Is it possible to have a test leverage this newly gained capability?
Now it's possible to do that, previously it would generate an invalid command-line, so a test can probably check for a successful diff call.
|
Let me know if this works for you. thanks! |
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
This looks great already!
I left a comment with a tiny last request to complete the M journey with a show case on how callers can now use it themselves :).
|
Hey Byron! |
|
Thanks a lot - doing it like this is fantastic and I couldn't imagine a way to better show the effect of the I will merge once CI runs through. Silly me aborted the existing Cygwin run because it seemed stuck, but history shows it's taking between 13 and 19 minutes to run there - incredible especially since the linux hosts are finished in less than 3 minutes. |
|
You're welcome! Thanks for your guidance and patience (This was my first PR). I really appreciate it! -Take care! |
2 participants
Small fix to allow overriding of default diff -M arg. Using --find-renames= or -M or --no-renames will disable -M.
Full discussion is here:
#1195